-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make helm charts consistent with how fields in spec are handled. (agent only) #8246
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Simplify esRefs. Signed-off-by: Michael Montgomery <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Co-authored-by: Peter Brachwitz <[email protected]>
Signed-off-by: Michael Montgomery <[email protected]>
Sorry for delays merging this, I was doing some additional testing manually, and have noticed a bit of an issue I believe with default values. I'll update with more information. |
Signed-off-by: Michael Montgomery <[email protected]>
…ored. Signed-off-by: Michael Montgomery <[email protected]>
This change right here: ebaf618#diff-300fb79f6e3cf107546b30ff8193e64ec1bbf8a52dbe5b5a86fd3dd4bdb83384R111-R116 was causing failures in the fleet-server chart, when using the eck-stack parent chart, and it wasn't caught in our tests and I was wondering why, as there was a test for it. I caught this in some manual testing. This change 6bbdc4f fixes that. @thbkrkr I'd really like for you to give this another look when you can please. |
Good catch, still LGTM. I guess we should do the same for suites declared in Not related to this PR, I took another look to values in examples and we could remove the
|
related: #8184
related: #8192
Details of suggested change
This is the follow-up to #8192, where we are making the eck-agent helm chart consistent in how it handles values that end up within
spec
, and making it backwards compatible.Implementation Note
.spec.field
in the values take precedence over justfield
in the values.spec.http.something
, and also settinghttp.somethingElse
)