[WIP] Make image setting consistent accross all ECK Helm charts
#8184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanfabrice
changed the title
image setting consistant accross all ECK Helm chartsimage setting consistent accross all ECK Helm charts
|
@jeanfabrice thanks for making this consistent. I'll look at this and see if there's a way to make it a non-breaking change. Maybe only use |
|
Thank you @naemono. There is certainly a more simpler and less breaking solution. I tried to apply the same logic we already have on ES charts. |
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have 4 Helm charts that implement the image setting and copy it to
.spec.imageWe have 3 others Helm charts (Kibnana, Elastic-Agent and Beat) that just copy the entire spec object from
values.yamlto the custom resource.specThe idea of this PR is to make all Helm Charts consistent while exposing the
imagesetting for clarityIt implies breaking changes. I don't know (yet) how we version / handle Helm charts breaking changes at the Helm charts level.