-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ZDC LYSO Pedestal Sigma Parameter #1541
Closed
Closed
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
215bad5
Changed ZDC LYSO Pedestal Sigma Parameter
JiaJunHuang120000 8de0cfb
Changed ZDC LYSO Pedestal Sigma Parameter
JiaJunHuang120000 ab4373e
Merge branch 'main' into zdc_lyso
JiaJunHuang120000 32e3019
Update ZDC.cc
bschmookler cf8dc64
Merge branch 'main' into zdc_lyso
bschmookler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, here you claim that 15-bit ADC can not resolve your pedestal. That is unrealistic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current parameters cause issues for O(5-10 MeV) photons. 5-10 MeV photons may be a reasonable lower limit target for the LYSO.
We do not have expected noise estimates yet. But the current version has a threshold cut at 4*3.2 = 12.8 ADC channels, which is a deposited energy per tower of about 0.8 MeV. For LYSO, a 0.8 MeV deposit corresponds to a light yield of about 25,000 photons.
If we don't want to decrease to pedestal width from 3.2 ADC channels, we maybe can decrease the dynamic range of the LYSO from the current 2 GeV value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current numbers should have been implemented following request of the Simulation group to DSC's. Ideally, the simulations reflect performance of the detector as can be constructed, not performance that is desired. Is it possible to get these updated parameters endorsed by DSCs?
My original comment about ADC is not meant to imply that ADC noise defines the floor, but to point out that ballpark numbers aren't feasible and that one could seek for a higher resolution ADC if the noise is less than one unit. Reducing dynamic range will not help for noise defined by the sensor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Thanks. We'll chat with the DSC about the parameter values.