Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ZDC LYSO Pedestal Sigma Parameter #1541

Closed
wants to merge 5 commits into from
Closed

Conversation

JiaJunHuang120000
Copy link

@JiaJunHuang120000 JiaJunHuang120000 commented Jul 31, 2024

Briefly, what does this PR introduce?

Correct ZDC LYSO pedestal sigma parameter to for accurate reconstruction of low energy photons. Currently each ADC channel correspond to 0.06 MeV, and with previous value of pedestal sigma towers with energy less than 0.08 MeV were removed. Now, towers with lower energy deposites are kept.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: Parameter Update

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators @bschmookler

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

Only in ZDC ECal.

@github-actions github-actions bot added topic: calorimetry relates to calorimetry topic: far-forward Far forward reconstruction labels Jul 31, 2024
@JiaJunHuang120000 JiaJunHuang120000 changed the title Zdc lyso Update ZDC LYSO Pedestal Sigma Parameter Jul 31, 2024
@@ -33,7 +33,7 @@ extern "C" {
.capADC = 32768,
.dyRangeADC = 2000 * dd4hep::MeV,
.pedMeanADC = 400,
.pedSigmaADC = 3.2,
.pedSigmaADC = 0.2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, here you claim that 15-bit ADC can not resolve your pedestal. That is unrealistic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current parameters cause issues for O(5-10 MeV) photons. 5-10 MeV photons may be a reasonable lower limit target for the LYSO.

We do not have expected noise estimates yet. But the current version has a threshold cut at 4*3.2 = 12.8 ADC channels, which is a deposited energy per tower of about 0.8 MeV. For LYSO, a 0.8 MeV deposit corresponds to a light yield of about 25,000 photons.

If we don't want to decrease to pedestal width from 3.2 ADC channels, we maybe can decrease the dynamic range of the LYSO from the current 2 GeV value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current numbers should have been implemented following request of the Simulation group to DSC's. Ideally, the simulations reflect performance of the detector as can be constructed, not performance that is desired. Is it possible to get these updated parameters endorsed by DSCs?

My original comment about ADC is not meant to imply that ADC noise defines the floor, but to point out that ballpark numbers aren't feasible and that one could seek for a higher resolution ADC if the noise is less than one unit. Reducing dynamic range will not help for noise defined by the sensor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks. We'll chat with the DSC about the parameter values.

@veprbl
Copy link
Member

veprbl commented Aug 1, 2024

This appears to break your benchmark: https://eicweb.phy.anl.gov/EIC/benchmarks/detector_benchmarks/-/jobs/3574966#L3615 edit: not anymore (benchmark updated)

@bschmookler bschmookler marked this pull request as draft August 12, 2024 16:14
Copy link

@@ -64,7 +64,7 @@ extern "C" {
{
.sectorDist = 5.0 * dd4hep::cm,
.localDistXY = {50 * dd4hep::cm, 50 * dd4hep::cm},
.dimScaledLocalDistXY = {50.0*dd4hep::mm, 50.0*dd4hep::mm},
.dimScaledLocalDistXY = {5, 5},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likely not going to work since you rely on buggy behavior fixed in #1598.

github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
### Briefly, what does this PR introduce?
This PR updates the digitization parameters for the SiPM-on-Tile ZDC.
The current default parameters place a zero-suppression threshold at 40
ADC channels. With a 15-bit ADC with dynamic range of 800 MeV, this is a
cut at 0.98 MeV (~ 2 MIPs). We see that this has an impact on the energy
reconstruction for single-particle simulations.

This PR changes following values:

```
ADC Capacity = 16-bit (65536 channels)
DynamicRange = 1000 MeV (0.015 MeV per ADC channel)
pedSigmaADC = 2
thresholdFactor = 3.0
```

These parameters are realistic. The HGROC ASIC can have a capacity of
16-bits; a high-energy photon shower can leave up to 800-1000 MeV in a
single channel; and a zero-suppression cut of 6 ADC channels (0.2 MIPs)
will allow studies of threshold cuts in the 0.2-0.5 MIP range.

The above changes have been discussed with the SiPM-on-Tile DSC lead,
Miguel Arratia.

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [x] Other: Digitization parameters update

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [x] Changes have been communicated to collaborators Discussed with
@sebouh137 and M. Arratia

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No.

### Does this PR change default behavior?
Yes, for SiPM-on-Tile ZDC

Closes: #1541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: calorimetry relates to calorimetry topic: far-forward Far forward reconstruction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants