Skip to content

Commit

Permalink
eicrecon_cli: disable parameter tables for JANA2 2.3.x (#1614)
Browse files Browse the repository at this point in the history
Users will be notified about a way to re-enable the parameter table:
https://github.com/JeffersonLab/JANA2/blob/a439a5682586bf4ba951a9723aa0d4cf55015e35/src/libraries/JANA/Services/JParameterManager.cc#L127

### Briefly, what does this PR introduce?
Reduce amount of output

### What kind of change does this PR introduce?
- [ ] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No

### Does this PR change default behavior?
Yes
  • Loading branch information
veprbl authored Sep 12, 2024
1 parent df5ece6 commit af290dc
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions src/utilities/eicrecon/eicrecon_cli.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -377,9 +377,6 @@ int Execute(JApplication* app, UserOptions& options) {

std::cout << std::endl;

// std::cout << "JANA " << JVersion::GetVersion() << " [" << JVersion::GetRevision() << "]" <<
// std::endl;

if (options.flags[ShowConfigs]) {
// Load all plugins, collect all parameters, exit without running anything
app->Initialize();
Expand Down Expand Up @@ -407,6 +404,12 @@ int Execute(JApplication* app, UserOptions& options) {
// TODO: more elegant processing here
PrintPodioCollections(app);
} else {
if ((JVersion::GetMajorNumber() == 2) && (JVersion::GetMinorNumber() == 3) && (JVersion::GetPatchNumber() <= 1)) {
// JANA2 2.3.x has a bug with not filtering default-state parameters, which causes enormous printouts
if (not app->GetJParameterManager()->Exists("jana:parameter_verbosity")) {
app->GetJParameterManager()->SetParameter("jana:parameter_verbosity", 0);
}
}
// Run JANA in normal mode
try {
JSignalHandler::register_handlers(app);
Expand Down

0 comments on commit af290dc

Please sign in to comment.