Skip to content

Commit

Permalink
JEventProcessorPODIO: make podio:output_include_collection deprecat…
Browse files Browse the repository at this point in the history
…ion warning more compelling (#1606)

### Briefly, what does this PR introduce?

This improves the wording to actually help general users get rid of the
delay, that they may not know about.

### What kind of change does this PR introduce?
- [x] Bug fix (issue #__)
- [ ] New feature (issue #__)
- [ ] Documentation update
- [ ] Other: __

### Please check if this PR fulfills the following:
- [ ] Tests for the changes have been added
- [ ] Documentation has been added / updated
- [ ] Changes have been communicated to collaborators

### Does this PR introduce breaking changes? What changes might users
need to make to their code?
No

### Does this PR change default behavior?
No
  • Loading branch information
veprbl authored Sep 11, 2024
1 parent 4daa6b0 commit df5ece6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/services/io/podio/JEventProcessorPODIO.cc
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ void JEventProcessorPODIO::Init() {
// I definitely don't trust PODIO to do this for me.

if (m_output_include_collections_set) {
m_log->error("The podio:output_include_collections was provided, but is deprecated. Use podio:output_collections instead.");
m_log->error("The podio:output_include_collections was provided, but is deprecated. Use podio:output_collections instead. Address this to remove the 10 second delay.");
// Adding a delay to ensure users notice the deprecation warning.
using namespace std::chrono_literals;
std::this_thread::sleep_for(10s);
Expand Down Expand Up @@ -548,7 +548,7 @@ void JEventProcessorPODIO::Process(const std::shared_ptr<const JEvent> &event) {

void JEventProcessorPODIO::Finish() {
if (m_output_include_collections_set) {
m_log->error("The podio:output_include_collections was provided, but is deprecated. Use podio:output_collections instead.");
m_log->error("The podio:output_include_collections was provided, but is deprecated. Use podio:output_collections instead. Address this to remove the 10 second delay.");
// Adding a delay to ensure users notice the deprecation warning.
using namespace std::chrono_literals;
std::this_thread::sleep_for(10s);
Expand Down

0 comments on commit df5ece6

Please sign in to comment.