Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add missing deps #654

Closed
wants to merge 2 commits into from
Closed

chore: add missing deps #654

wants to merge 2 commits into from

Conversation

lifeiscontent
Copy link
Contributor

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd21cf0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

edmundhung
edmundhung reviewed May 29, 2024
View reviewed changes
Copy link
Owner

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Sorry I didn't notice you made this PR and I have just merged another PR that add the missing pkg.

packages/conform-dom/.gitignore
*.cjs
*.d.ts
*.js
*.mjs
LICENSE
Copy link
Owner

@edmundhung edmundhung May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not copying the LICENSE anymore as pnpm will handle that for us

Copy link
Contributor Author

@lifeiscontent lifeiscontent May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I ran pnpm i I noticed the prepare script copied it into the folder

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be running an older version. I removed the settings for copying the LICENSE last night.

packages/conform-dom/.gitignore
@@ -1,7 +1,8 @@
_virtual
!rollup.config.js
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any difference with the order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I just sorted it for readability

@lifeiscontent
Copy link
Contributor Author

@edmundhung if this is all sorted in main feel free to close, was just trying to help :)

@edmundhung
Copy link
Owner

Closing this as the missing package is already added. Thanks again :)

@edmundhung edmundhung closed this May 29, 2024
@lifeiscontent lifeiscontent deleted the chore/add-missing-deps branch May 30, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmundhung edmundhung edmundhung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lifeiscontent @edmundhung