Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing deps #654

Closed
wants to merge 2 commits into from
Closed

chore: add missing deps #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab4eaec
chore: add missing deps
lifeiscontent May 29, 2024
fd21cf0
Merge branch 'main' into chore/add-missing-deps
lifeiscontent May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"prepare": "husky install"
},
"devDependencies": {
"@changesets/changelog-github": "^0.5.0",
"@changesets/cli": "^2.27.5",
"@conform-to/dom": "workspace:*",
"@conform-to/react": "workspace:*",
Expand Down
3 changes: 2 additions & 1 deletion packages/conform-dom/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
_virtual
!rollup.config.js
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any difference with the order?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, I just sorted it for readability

*.cjs
*.d.ts
*.js
*.mjs
LICENSE
Copy link
Owner

@edmundhung edmundhung May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not copying the LICENSE anymore as pnpm will handle that for us

Copy link
Contributor Author

@lifeiscontent lifeiscontent May 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I ran pnpm i I noticed the prepare script copied it into the folder

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be running an older version. I removed the settings for copying the LICENSE last night.

README
!rollup.config.js
3 changes: 2 additions & 1 deletion packages/conform-react/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
_virtual
!rollup.config.js
*.cjs
*.d.ts
*.js
*.mjs
LICENSE
README
!rollup.config.js
3 changes: 2 additions & 1 deletion packages/conform-validitystate/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
_virtual
!rollup.config.js
*.cjs
*.d.ts
*.js
*.mjs
LICENSE
README
!rollup.config.js
3 changes: 2 additions & 1 deletion packages/conform-yup/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
_virtual
!rollup.config.js
*.cjs
*.d.ts
*.js
*.mjs
LICENSE
README
!rollup.config.js
3 changes: 2 additions & 1 deletion packages/conform-zod/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
_virtual
!rollup.config.js
*.cjs
*.d.ts
*.js
*.mjs
LICENSE
README
!rollup.config.js
35 changes: 35 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading