Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding list updated after moving serialization to zenoh-ext #1512

Closed
wants to merge 9 commits into from
Closed

encoding list updated after moving serialization to zenoh-ext #1512

wants to merge 9 commits into from

Conversation

milyin
Copy link
Contributor

@milyin milyin commented Oct 4, 2024

fix for #1507

@milyin milyin requested a review from wyfo October 4, 2024 12:09
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

PR missing one of the required labels: {'dependencies', 'enhancement', 'new feature', 'internal', 'bug', 'breaking-change', 'documentation'}

@milyin milyin added breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime) api fix Correct API labels Oct 4, 2024
@milyin
Copy link
Contributor Author

milyin commented Oct 4, 2024

The fix replaces all zenoh primitive encoding types to ZENOH_SERIALIZED encoding.
Also it removes encoding zenoh/error for ReplyError as useless: in reality ReplyError structure contains payload and encoding, i.e. error reply may have any encoding, ZENOH_ERROR encoding is not used

@milyin milyin mentioned this pull request Oct 4, 2024
Closed
@milyin milyin marked this pull request as draft October 4, 2024 14:36
@fuzzypixelz fuzzypixelz mentioned this pull request Oct 7, 2024
Merged
@milyin milyin marked this pull request as ready for review October 7, 2024 23:58
@milyin milyin closed this Oct 8, 2024
@milyin milyin reopened this Oct 8, 2024
@milyin milyin mentioned this pull request Oct 8, 2024
Closed
7 tasks
@milyin milyin marked this pull request as draft October 9, 2024 15:19
@milyin
Copy link
Contributor Author

milyin commented Oct 9, 2024

overriden by #1520

@milyin milyin closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DenisBiryukov91 DenisBiryukov91 DenisBiryukov91 approved these changes

@wyfo wyfo Awaiting requested review from wyfo

Assignees
No one assigned
Labels
api fix Correct API breaking-change Indicates that the issue implies a breaking change (be it at compile time or at runtime)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milyin @DenisBiryukov91