rework list of predefined encodings #1507
Labels
api fix
Correct API
breaking-change
Indicates that the issue implies a breaking change (be it at compile time or at runtime)
release
Part of the next release
umbrella
The task which covers multiple other tasks
Describe the release item
There are several predefined encodings which became ambigious after serialization rework in #1474. The main reason of ambiguity is that the prefix
ZENOH_
for encoding doesn't say anything is serialization used or not.E.g. is
ZENOH_STRING
means thatZBytes::to_string()
was used or string was serialized intoZBytes
. The difference is important: in second case the string is additionally prefixed by length.Same for
ZENOH_BYTES
value: is itZBytes::to_bytes()
or serialization of vector ofu8
. Difference is the same: justto_bytes()
doesn't add any prefixThe proposal is to
ZENOH_STRING
andZENOH_BYTES
, they should correspond toZBytes::to_string()
,ZBytes::to_bytes()
ZENOH_SERIALIZED
. it's suffix can be used to store serializing schemaZENOH_INT8
,ZENOH_INT16
, etcThe fixes should be also propagated to bindings
The text was updated successfully, but these errors were encountered: