Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch Windows z_clock to QueryPerformanceCounter #310

Merged
merged 4 commits into from
Jan 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/windows/z_ping.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ int main(int argc, char** argv) {
results[i] = z_clock_elapsed_us(&measure_start);
}
for (unsigned int i = 0; i < args.number_of_pings; i++) {
printf("%d bytes: seq=%d rtt=%luµs, lat=%luµs\n", args.size, i, results[i], results[i] / 2);
printf("%d bytes: seq=%d rtt=%luus, lat=%luus\n", args.size, i, results[i], results[i] / 2);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows shell is really bad at parsing anything else than ASCII

}
_z_mutex_unlock(&mutex);
z_free(results);
Expand Down
2 changes: 1 addition & 1 deletion include/zenoh-pico/system/platform/windows.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ typedef SRWLOCK _z_mutex_t;
typedef CONDITION_VARIABLE _z_condvar_t;
#endif // Z_FEATURE_MULTI_THREAD == 1

typedef struct timeb z_clock_t;
typedef LARGE_INTEGER z_clock_t;
typedef struct timeb z_time_t;

typedef struct {
Expand Down
4 changes: 2 additions & 2 deletions src/session/scout.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ _z_hello_list_t *__z_scout_loop(const _z_wbuf_t *wbf, const char *locator, unsig
// The receiving buffer
_z_zbuf_t zbf = _z_zbuf_make(Z_BATCH_UNICAST_SIZE);

z_time_t start = z_time_now();
while (z_time_elapsed_ms(&start) < period) {
z_clock_t start = z_clock_now();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

z_clock_t is more adapted than z_time_t to a timeout implementation like here

while (z_clock_elapsed_ms(&start) < period) {
// Eventually read hello messages
_z_zbuf_reset(&zbf);

Expand Down
46 changes: 36 additions & 10 deletions src/system/windows/system.c
Original file line number Diff line number Diff line change
Expand Up @@ -177,26 +177,52 @@
/*------------------ Instant ------------------*/
z_clock_t z_clock_now(void) {
z_clock_t now;
ftime(&now);
QueryPerformanceCounter(&now);
return now;
}

unsigned long z_clock_elapsed_us(z_clock_t *instant) { return z_clock_elapsed_ms(instant) * 1000; }
unsigned long z_clock_elapsed_us(z_clock_t *instant) {

Check warning

Code scanning / Cppcheck (reported by Codacy)

misra violation 804 with no text in the supplied rule-texts-file Warning

misra violation 804 with no text in the supplied rule-texts-file

Check warning

Code scanning / Cppcheck (reported by Codacy)

Parameter 'instant' can be declared as pointer to const Warning

Parameter 'instant' can be declared as pointer to const
z_clock_t now;
LARGE_INTEGER frequency;
QueryPerformanceCounter(&now);
QueryPerformanceFrequency(&frequency); // ticks per second

// Hardware not supporting QueryPerformanceFrequency
if (frequency.QuadPart == 0) {
return 0;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.5 rule Note

MISRA 15.5 rule
}
double elapsed = (double)(now.QuadPart - instant->QuadPart) * 1000000.0;
elapsed /= frequency.QuadPart;
return (unsigned long)elapsed;
}

unsigned long z_clock_elapsed_ms(z_clock_t *instant) {
z_time_t now;
ftime(&now);
z_clock_t now;
LARGE_INTEGER frequency;
QueryPerformanceCounter(&now);
QueryPerformanceFrequency(&frequency); // ticks per second

unsigned long elapsed = ((unsigned long)(now.time - instant->time) * 1000) + (now.millitm - instant->millitm);
return elapsed;
// Hardware not supporting QueryPerformanceFrequency
if (frequency.QuadPart == 0) {
return 0;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.5 rule Note

MISRA 15.5 rule
}
double elapsed = (double)(now.QuadPart - instant->QuadPart) * 1000.0;
elapsed /= frequency.QuadPart;
return (unsigned long)elapsed;
}

unsigned long z_clock_elapsed_s(z_clock_t *instant) {
z_time_t now;
ftime(&now);
z_clock_t now;
LARGE_INTEGER frequency;
QueryPerformanceCounter(&now);
QueryPerformanceFrequency(&frequency); // ticks per second

unsigned long elapsed = (unsigned long)(now.time - instant->time);
return elapsed;
// Hardware not supporting QueryPerformanceFrequency
if (frequency.QuadPart == 0) {
return 0;

Check notice

Code scanning / Cppcheck (reported by Codacy)

MISRA 15.5 rule Note

MISRA 15.5 rule
}
double elapsed = (double)(now.QuadPart - instant->QuadPart) / frequency.QuadPart;
return (unsigned long)elapsed;
}

/*------------------ Time ------------------*/
Expand Down
Loading