Switch Windows z_clock to QueryPerformanceCounter #310
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return now; | ||
| } | ||
|
|
||
| unsigned long z_clock_elapsed_us(z_clock_t *instant) { return z_clock_elapsed_ms(instant) * 1000; } | ||
| unsigned long z_clock_elapsed_us(z_clock_t *instant) { |
Check warning
Code scanning / Cppcheck (reported by Codacy)
misra violation 804 with no text in the supplied rule-texts-file Warning
| return now; | ||
| } | ||
|
|
||
| unsigned long z_clock_elapsed_us(z_clock_t *instant) { return z_clock_elapsed_ms(instant) * 1000; } | ||
| unsigned long z_clock_elapsed_us(z_clock_t *instant) { |
Check warning
Code scanning / Cppcheck (reported by Codacy)
Parameter 'instant' can be declared as pointer to const Warning
|
|
||
| // Hardware not supporting QueryPerformanceFrequency | ||
| if (frequency.QuadPart == 0) { | ||
| return 0; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.5 rule Note
| return elapsed; | ||
| // Hardware not supporting QueryPerformanceFrequency | ||
| if (frequency.QuadPart == 0) { | ||
| return 0; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.5 rule Note
| return elapsed; | ||
| // Hardware not supporting QueryPerformanceFrequency | ||
| if (frequency.QuadPart == 0) { | ||
| return 0; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.5 rule Note
| @@ -113,7 +113,7 @@ int main(int argc, char** argv) { | |||
| results[i] = z_clock_elapsed_us(&measure_start); | |||
| } | |||
| for (unsigned int i = 0; i < args.number_of_pings; i++) { | |||
| printf("%d bytes: seq=%d rtt=%luµs, lat=%luµs\n", args.size, i, results[i], results[i] / 2); | |||
| printf("%d bytes: seq=%d rtt=%luus, lat=%luus\n", args.size, i, results[i], results[i] / 2); | |||
There was a problem hiding this comment.
Windows shell is really bad at parsing anything else than ASCII
| @@ -55,8 +55,8 @@ _z_hello_list_t *__z_scout_loop(const _z_wbuf_t *wbf, const char *locator, unsig | |||
| // The receiving buffer | |||
| _z_zbuf_t zbf = _z_zbuf_make(Z_BATCH_UNICAST_SIZE); | |||
|
|
|||
| z_time_t start = z_time_now(); | |||
| while (z_time_elapsed_ms(&start) < period) { | |||
| z_clock_t start = z_clock_now(); | |||
There was a problem hiding this comment.
z_clock_t is more adapted than z_time_t to a timeout implementation like here
As stated in #272, the Windows
z_clockimplementation was the same asz_timewhich wasn't ideal.This PR aligns
z_clockwith the Rust clock implementation that uses Windows' QueryPerformanceCounter.As a bonus, it switches the scout timeout loop to
z_clockinstead ofz_timewhich is more suited.