Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align the default value of reliability #351

Merged
merged 4 commits into from
Jan 7, 2025
Merged

fix: align the default value of reliability #351

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcd8937
fix: align the default value of reliability
YuanYuYuan Dec 24, 2024
ff686d6
chore: address the comment
YuanYuYuan Jan 7, 2025
6ce2504
style: clang-format
YuanYuYuan Jan 7, 2025
6e268d4
fix: compile failure
YuanYuYuan Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions include/zenoh/api/session.hxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,7 @@ class Session : public Owned<::z_owned_session_t> {
/// @warning This API has been marked as unstable: it works as advertised, but it may be changed in a future
/// release.
/// @brief The delete operation reliability.
Reliability reliability = Reliability::Z_RELIABILITY_BEST_EFFORT;
Reliability reliability = z_reliability_default();
#endif
/// @brief the timestamp of this message.
std::optional<Timestamp> timestamp = {};
Expand Down Expand Up @@ -588,7 +588,7 @@ class Session : public Owned<::z_owned_session_t> {
/// @warning This API has been marked as unstable: it works as advertised, but it may be changed in a future
/// release.
/// @brief The put operation reliability.
Reliability reliability = Reliability::Z_RELIABILITY_BEST_EFFORT;
Reliability reliability = z_reliability_default();
#endif
#if defined(ZENOHCXX_ZENOHC) && defined(Z_FEATURE_UNSTABLE_API)
/// @warning This API has been marked as unstable: it works as advertised, but it may be changed in a future
Expand Down Expand Up @@ -648,7 +648,7 @@ class Session : public Owned<::z_owned_session_t> {
/// @warning This API has been marked as unstable: it works as advertised, but it may be changed in a future
/// release.
/// @brief The publisher reliability.
Reliability reliability = Reliability::Z_RELIABILITY_BEST_EFFORT;
Reliability reliability = z_reliability_default();
#endif
#if defined(ZENOHCXX_ZENOHC) && defined(Z_FEATURE_UNSTABLE_API)
/// @warning This API has been marked as unstable: it works as advertised, but it may be changed in a future
Expand Down
Loading