fix: align the default value of reliability #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR missing one of the required labels: {'dependencies', 'new feature', 'enhancement', 'internal', 'breaking-change', 'documentation', 'bug'} |
YuanYuYuan
added
api sync
include/zenoh/api/session.hxx
Outdated
| @@ -532,7 +532,7 @@ class Session : public Owned<::z_owned_session_t> { | |||
| /// @warning This API has been marked as unstable: it works as advertised, but it may be changed in a future | |||
| /// release. | |||
| /// @brief The delete operation reliability. | |||
| Reliability reliability = Reliability::Z_RELIABILITY_BEST_EFFORT; | |||
| Reliability reliability = Reliability::Z_RELIABILITY_RELIABLE; | |||
There was a problem hiding this comment.
I would rather replace it just with = z_reliability_default.
There was a problem hiding this comment.
Yes. It's better. Updated.
YuanYuYuan
force-pushed
the
fix/align-reliability
branch
from
eda951c to
ff686d6
Compare
|
@DenisBiryukov91 I've rebased it to the main branch and applied your suggestion. Can you have a look? |
DenisBiryukov91
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the same default reliability value as zenoh rust.