Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: owned queries now supported, allowing responses out of callback #213

Merged
merged 5 commits into from
Dec 4, 2023

Conversation

p-avital
Copy link
Contributor

@p-avital p-avital commented Dec 4, 2023

No description provided.

@p-avital p-avital requested a review from JEnoch December 4, 2023 10:35
Cargo.toml Show resolved Hide resolved
* When the last `z_owned_query_t` corresponding to a query is destroyed, or the callback that produced the query cloned to build them returns,
* the query will receive its termination signal.
*
* Holding onto an `z_owned_query_t` for too long (10s by default) will trigger a timeout error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the way to change this 10s default timeout on Queryable side ?

include/zenoh_commons.h Show resolved Hide resolved
Copy link
Member

@JEnoch JEnoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JEnoch JEnoch merged commit 16cba07 into master Dec 4, 2023
6 checks passed
This was referenced Dec 6, 2023
@Mallets Mallets deleted the feat/owned_queries branch December 7, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants