Adds missing zenoh_loan_type explicit instanciation for query. #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Franco Cipollone <[email protected]>
|
Sorry for going ahead and dropping this PR, let me know if I should just close it and create an issue. 👍 |
|
Hello @francocipollone , Thanks for your PR! You will need to sign the Eclipse Contribution Agreement. Otherwise we won't be able to merge the PR as it is. |
|
No issue (and none needed), thanks for noticing I missed this one :) However, if you want your PR merged, you're going to have to signed the ECA :) |
p-avital
approved these changes
Dec 4, 2023
On it 😄 , I think I did it correctly but I hit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing explicit template instantiation for loaning the
z_owned_query_tContext
Follow-up PR from #213