Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: align portal iam doc structure with trg 1 #207

Conversation

shahmargi12
Copy link
Contributor

@shahmargi12 shahmargi12 commented Oct 15, 2024

Description

  • Restructured existing documents according to the new TRG 1 folder hierarchy.
  • Created a new README.md with links to the relevant files and subfolders, ensuring all documents are properly referenced and accessible.

Structure that followed in PR -

repository
└─── docs/
    └─── admin/
         └─── technical-documentation/
         └─── dev-process/
         └─── release-process/
         └─── known-knowns/
    └─── consultation/
         └─── portal-iam-helm.chart.md
         └─── charts/
         └─── environment/
         └─── workshops/
         └─── consultation.md
    └─── README.md

Why

To align with TRG 1

Issue

#187

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have added copyright and license headers, footers (for .md files) or files (for images)
  • I have performed a self-review of my changes
  • I have successfully tested my changes

@shahmargi12 shahmargi12 changed the title docs: 187 align portal iam doc structure with trg 1 docs: align portal iam doc structure with trg 1 Oct 15, 2024
@shahmargi12
Copy link
Contributor Author

Hello @evegufy @MaximilianHauer

I noticed that the quality gate is failing due to some issues in the YAML files. The only change I made related to these files is moving their folder location, without modifying the content itself.

Could you please take a look and help me resolve the issue? It seems like the errors might be triggered by the folder restructuring.

@evegufy
Copy link
Contributor

evegufy commented Oct 23, 2024

Hello @evegufy @MaximilianHauer

I noticed that the quality gate is failing due to some issues in the YAML files. The only change I made related to these files is moving their folder location, without modifying the content itself.

Could you please take a look and help me resolve the issue? It seems like the errors might be triggered by the folder restructuring.

@shahmargi12 thank you for the contribution!
Regarding sonarcloud: could you please add such a file https://github.com/eclipse-tractusx/portal-frontend/blob/main/.sonarcloud.properties where you exclude the docs directory? https://stackoverflow.com/questions/21323276/sonarqube-exclude-a-directory Thank you!

@shahmargi12
Copy link
Contributor Author

@evegufy I’ve updated the .sonarcloud.properties file to exclude the docs directory. You can find the details in this PR: #1275.
Thank you!

@shahmargi12
Copy link
Contributor Author

shahmargi12 commented Oct 25, 2024

Hello @evegufy
Apologies for the earlier confusion. I’ve updated the sonarcloud.properties file to ignore the .yaml file inside the docs folder.

Let me know if you need any further adjustments.

@evegufy
Copy link
Contributor

evegufy commented Nov 6, 2024

Hello @evegufy Apologies for the earlier confusion. I’ve updated the sonarcloud.properties file to ignore the .yaml file inside the docs folder.

Let me know if you need any further adjustments.

@shahmargi12 perfect, thank you! sorry, I didn't remember that there is already a sonarcloud.properties and the existing one could to be updated.

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look and as architecture and user documentation doesn't exist in this repo, I think it makes sense to restructure like this:

repository
└─── docs/
    └─── admin/
         └─── technical-documentation/
         └─── known-knowns/
         └─── dev-process/
         └─── release-process/
    └─── consultation/
         └─── portal-iam-helm.chart.md
         └─── charts/
         └─── environment/
         └─── workshops/
         └─── consultation.md
    └─── README.md

@shahmargi12
Copy link
Contributor Author

shahmargi12 commented Nov 7, 2024

I had a look and as architecture and user documentation doesn't exist in this repo, I think it makes sense to restructure like this:

repository
└─── docs/
    └─── admin/
         └─── technical-documentation/
         └─── known-knowns/
         └─── dev-process/
         └─── release-process/
    └─── consultation/
         └─── portal-iam-helm.chart.md
         └─── charts/
         └─── environment/
         └─── workshops/
         └─── consultation.md
    └─── README.md

@evegufy Thanks for the suggestion! I’ve restructured the documentation according to your recommendations.

@shahmargi12 shahmargi12 requested a review from evegufy November 7, 2024 06:11
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good, thank you @shahmargi12

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I noticed that there's still a change needed

docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
shahmargi12 and others added 3 commits November 7, 2024 14:30
Co-authored-by: Evelyn Gurschler <[email protected]>
Co-authored-by: Evelyn Gurschler <[email protected]>
Co-authored-by: Evelyn Gurschler <[email protected]>
Copy link

sonarqubecloud bot commented Nov 7, 2024

@shahmargi12
Copy link
Contributor Author

shahmargi12 commented Nov 7, 2024

sorry I noticed that there's still a change needed

@evegufy I’ve made the change as requested. Let me know if there's anything else that needs updating.

@shahmargi12 shahmargi12 requested a review from evegufy November 7, 2024 09:05
@evegufy evegufy merged commit 32509c7 into eclipse-tractusx:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: USER READY
Development

Successfully merging this pull request may close these issues.

2 participants