Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer registering SaveParticipant until IWorkspace service is available #752

Merged
merged 4 commits into from
Oct 21, 2023
Merged

Defer registering SaveParticipant until IWorkspace service is available #752

merged 4 commits into from
Oct 21, 2023

Commits on Oct 20, 2023

  1. Defer registering SaveParticipant until IWorkspace service is available 

    This fixes the issue "IllegalStateException: Workspace is already closed
or not ready yet" when the bundle is started early

This closes eclipse-platform#748
    @kwin
    kwin committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    ef7b92d View commit details
    Browse the repository at this point in the history

  2. Also remove the saveParticipant in ServiceTracker

    @kwin
    kwin committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8dc1af6 View commit details
    Browse the repository at this point in the history

  3. rely on default methods for getting service

    @kwin
    kwin committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    9dcdc36 View commit details
    Browse the repository at this point in the history

  4. Improved error handling 

    Rely on BundleContext.(un)getService(...) instead of ServiceTracker impl
    @kwin
    kwin committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    9518cf0 View commit details
    Browse the repository at this point in the history