Defer registering SaveParticipant until IWorkspace service is available #752
Conversation
This fixes the issue "IllegalStateException: Workspace is already closed or not ready yet" when the bundle is started early This closes eclipse-platform#748
debug/org.eclipse.debug.core/core/org/eclipse/debug/core/DebugPlugin.java
Show resolved
Hide resolved
Test Results 42 files + 6 42 suites +6 53m 43s ⏱️ + 5m 8s For more details on these failures, see this check. Results for commit 9518cf0. ± Comparison against base commit cfb3c5f. ♻️ This comment has been updated with latest results. |
debug/org.eclipse.debug.core/core/org/eclipse/debug/core/DebugPlugin.java
Show resolved
Hide resolved
debug/org.eclipse.debug.core/core/org/eclipse/debug/core/DebugPlugin.java
Show resolved
Hide resolved
Rely on BundleContext.(un)getService(...) instead of ServiceTracker impl
There was a problem hiding this comment.
I approve this here as extending ST or using STC is a style question.
What I wonder is if we probably should just push this down to the ResourcesPlugin as an abstract class (e.g. WorkspaceTracker) with two abstract methods like
WorkspaceTracker#onOpen(IWorkspace workspace)WorkspaceTracker#onClose(IWorkspace workspace)
so this can easily be reused at other places.
|
@kwin please verify this on the next integration build (somewhere available around tomorrow) |
|
@laeubi Where is the p2 update site of the integration build for platform? I only found the outdated documentation at https://wiki.eclipse.org/Eclipse_Project_Update_Sites... and 2023-12 m2 (i.e. https://download.eclipse.org/technology/epp/packages/2023-12/202310261200/ and https://download.eclipse.org/releases/2023-12/202310271000/) contains an older version of debug.core (3.21.200.v20230920-0608) |
|
You can use update site from last successful IBuild, like from https://download.eclipse.org/eclipse/downloads/drops4/I20231028-1800/ this would be then https://download.eclipse.org/eclipse/updates/4.30-I-builds/I20231028-1800/ |
This fixes the issue "IllegalStateException: Workspace is already closed or not ready yet" when the bundle is started early
This closes #748