Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Commit only relevant files in version increment workflow #2402

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Sep 28, 2024

Do not just commit every changed file in order to avoid accidental commits of resources changed or generated during builds. For version increments only the following files are relevant:

  • META-INF/MANIFEST.MF
  • feature.xml
  • pom.xml

This became relevant for example in eclipse-jdt/eclipse.jdt.debug#516 (comment).

Follow-up on #2352.

Do not just commit every changed file in order to avoid accidental
commits of resources changed or generated during builds.
For version increments only the following files are relevant:
- META-INF/MANIFEST.MF
- feature.xml
- pom.xml
@HannesWell
Copy link
Member Author

This is not tested by the verification build, but I tested it in my test-setup of this workflow.

Submitting.

@HannesWell HannesWell merged commit 9e7f462 into eclipse-platform:master Sep 28, 2024
3 of 4 checks passed
@HannesWell HannesWell deleted the commit-specific-files-in-version-increment branch September 28, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant