Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up workflow for automated version increments in pull-requests #516

Merged

Conversation

HannesWell
Copy link
Contributor

Set up for this repository the workflow for automated version increments in pull-requests added via eclipse-platform/eclipse.platform.releng.aggregator#2352

The EF infra team has already added the required PAT of the Platform-bot to this repo as requested via

Author checklist

@HannesWell
Copy link
Contributor Author

Same question as in eclipse-jdt/eclipse.jdt.core#3021 (comment).

@HannesWell
Copy link
Contributor Author

Looks like the build execution makes the git working tree dirty:

2 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 org.eclipse.jdt.debug.tests/javadebugtests.jar
create mode 100644 org.eclipse.jdt.debug/jdimodel.jar

@HannesWell
Copy link
Contributor Author

Looks like the build execution makes the git working tree dirty:

2 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 org.eclipse.jdt.debug.tests/javadebugtests.jar
create mode 100644 org.eclipse.jdt.debug/jdimodel.jar

These jar-files are generated from scratch during the build and I have added a .gitignore for them now.
But I think the version-increment workflow should be adapted to only commit files of interest, ignoring everything else.

@HannesWell
Copy link
Contributor Author

Looks like the build execution makes the git working tree dirty:

2 files changed, 0 insertions(+), 0 deletions(-)
create mode 100644 org.eclipse.jdt.debug.tests/javadebugtests.jar
create mode 100644 org.eclipse.jdt.debug/jdimodel.jar

These jar-files are generated from scratch during the build and I have added a .gitignore for them now. But I think the version-increment workflow should be adapted to only commit files of interest, ignoring everything else.

I have now enhanced the workflow so that this is not necessary anymore:

Same question as in eclipse-jdt/eclipse.jdt.core#3021 (comment).

The previous behavior is now preserved exactly as it is.

@iloveeclipse can you please review this?

@akurtakov akurtakov force-pushed the set-up-version-increment-workflow branch from 5ff6610 to 06ae5fa Compare September 30, 2024 12:46
@HannesWell
Copy link
Contributor Author

@iloveeclipse or @jukzi can this be completed too?

@akurtakov
Copy link
Contributor

Automatic version increments are really helpful. Merging.

@akurtakov akurtakov closed this Oct 1, 2024
@akurtakov akurtakov reopened this Oct 1, 2024
@akurtakov akurtakov merged commit 6218bff into eclipse-jdt:master Oct 1, 2024
14 checks passed
@HannesWell HannesWell deleted the set-up-version-increment-workflow branch October 1, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants