Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theia 1.45.1 #1047

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Theia 1.45.1 #1047

merged 2 commits into from
Feb 29, 2024

Commits on Feb 8, 2024

  1. update to latest Theia community release: v1.45.1

    Signed-off-by: Marc Dumais <[email protected]>
    marcdumais-work committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    ad4ad78 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. update following upstream Theia changes

    There were some recent Theia changes[1] that required to change the way our
    Theia extension starts. It used to be that our TraceServerUrlProviderImpl
    backend contribution could wait in the "initialize" Theia app life-cycle
    phase, until the application was started and it received the trace server
    port from the front-end, from our PreferencesFrontendContribution.
    
    But the above no longer works. Now backend contributions are started in
    parallel, and all are expected to finish their initialize phase, before the
    "start" phase is initiated.
    
    In practice, after upgrading to Theia v1.45.1, the Theia application, that
    includes the trace viewer extension,  would be killed during startup, with
    no clear indication why.
    
    To prevent this from happening, the need to receive information from the
    front-end, during initialization, has been removed: the backend contribution
    now initializes with the assumption that the default trace server port is used.
    If a different port is configured in the preferences, the information will be
    synched after the app has started.
    
    [1]: eclipse-theia/theia#12818
    
    specifically:
    
    "The BackendApplicatinContribution init and configure methods are now called
    in parallel for all contributions instead of sequentially."
    
    Signed-off-by: Marc Dumais <[email protected]>
    marcdumais-work committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bb87e0e View commit details
    Browse the repository at this point in the history