Theia 1.45.1 #1047
Merged
Theia 1.45.1 #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added
the
dependencies
marcdumais-work
force-pushed
the
theia_1.45.1
branch
from
d0532ff
to
af56966
Compare
There were some recent Theia changes[1] that required to change the way our Theia extension starts. It used to be that our TraceServerUrlProviderImpl backend contribution could wait in the "initialize" Theia app life-cycle phase, until the application was started and it received the trace server port from the front-end, from our PreferencesFrontendContribution. But the above no longer works. Now backend contributions are started in parallel, and all are expected to finish their initialize phase, before the "start" phase is initiated. In practice, after upgrading to Theia v1.45.1, the Theia application, that includes the trace viewer extension, would be killed during startup, with no clear indication why. To prevent this from happening, the need to receive information from the front-end, during initialization, has been removed: the backend contribution now initializes with the assumption that the default trace server port is used. If a different port is configured in the preferences, the information will be synched after the app has started. [1]: eclipse-theia/theia#12818 specifically: "The BackendApplicatinContribution init and configure methods are now called in parallel for all contributions instead of sequentially." Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
force-pushed
the
theia_1.45.1
branch
from
af56966
to
bb87e0e
Compare
bhufmann
approved these changes
Feb 28, 2024
| "@theia/preferences": "1.45.1", | ||
| "@theia/process": "1.45.1", | ||
| "@theia/terminal": "1.45.1", | ||
| "@theia/workspace": "1.45.1", | ||
| "theia-traceviewer": "0.2.0-next.20231206220005.ff0943f.0" |
There was a problem hiding this comment.
This needs to be updated after the a new version is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example apps to use the latest Theia community release.
There was an issue after the update, that required some digging. It turns-out that one of our backend contribution was no longer correctly following the expected life-cycle of a Theia application, causing the app to exit before being fully started.
TL;DR: our contribution would wait in the "initialize" phase until the application was fully started and one of our frontend contribution would send the trace server port. This has been refactored so that our backend contribution configures itself assuming the default port is used, and corrects this once the application is started (the port is only potentially needed later, when the user opens a trace).
See commit message for more details.
Note: because of the above, a bit more testing than usual is probably a good idea