Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the intermittently failing tests in SCXA #491

Merged
merged 13 commits into from
Dec 17, 2024
Merged

Fix the intermittently failing tests in SCXA #491

merged 13 commits into from
Dec 17, 2024

Conversation

ke4
Copy link
Contributor

@ke4 ke4 commented Nov 12, 2024 •
edited
Loading

This is a fix for a list of intermittently failing unit tests:

  • uk.ac.ebi.atlas.search.ToBeDeprecatedJsonGeneSearchControllerWIT.whenSearchTermExistsInDBThenReturnsSetOfCellType
  • uk.ac.ebi.atlas.search.organismpart.OrganismPartSearchDaoIT.whenValidCellIdsAndValidCellTypesProvidedReturnSetOfOrganismPart
  • uk.ac.ebi.atlas.search.ToBeDeprecatedJsonGeneSearchControllerWIT.jsonPayloadContainsFacetDescription
  • uk.ac.ebi.atlas.search.celltype.CellTypeSearchDaoIT.whenValidCellIdsAndValidProvidedReturnSetOfCellTypes

@ke4 ke4 added the bug Something isn't working label Nov 12, 2024
@ke4 ke4 self-assigned this Nov 12, 2024
@ke4 ke4 linked an issue Nov 12, 2024 that may be closed by this pull request
Intermittently failing unit tests in SCXA #489
Closed
4 tasks
@ke4 ke4 changed the title Remove all the duplicated tests that also presents in JsonGeneSearchControllerWIT Fix the intermittently failing tests in SCXA Nov 20, 2024
ke4 added 3 commits November 21, 2024 16:33
@ke4
Use exists method to filter out empty Solr documents
ebd7a02 
Also remove temporary logging added to run on CI
@ke4
Fix some tests in JsonGeneSearchControllerWIT
1f663c1 
Also ignore some that is going to be deprecated in the gene search refactor and hard to make it work
@ke4
Update submodules
a533373
@ke4 ke4 marked this pull request as ready for review November 22, 2024 11:39
@ke4 ke4 marked this pull request as draft November 22, 2024 12:30
@ke4
Copy link
Contributor Author

ke4 commented Nov 22, 2024

@lingyun1010 @upendrakumbham
I needed to put this PR back to draft, as I found another intermittently failing test.
I am going to work on that one from now on.
Thanks

@ke4 ke4 marked this pull request as ready for review November 25, 2024 10:29
@ke4
Copy link
Contributor Author

ke4 commented Nov 25, 2024

The 4th intermittent failing test is fixed now. I got a green build. ✅

@ke4 ke4 requested a review from lingyun1010 December 10, 2024 20:38
lingyun1010
lingyun1010 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@lingyun1010 lingyun1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please create a backlog ticket on the disabled test, in case we forget to bring it back? LGTM!

@lingyun1010 lingyun1010 mentioned this pull request Dec 13, 2024
Merged
@ke4
Copy link
Contributor Author

ke4 commented Dec 17, 2024

@lingyun1010 I have already created it: Investigate ToBeDeprecatedJsonGeneSearchControllerWIT intermittently failing test

@ke4 ke4 merged commit 501846c into develop Dec 17, 2024
3 checks passed
@ke4 ke4 deleted the bugfix/intermittently_failing_tests branch December 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lingyun1010 lingyun1010 lingyun1010 approved these changes

@upendrakumbham upendrakumbham Awaiting requested review from upendrakumbham

Assignees

@ke4 ke4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intermittently failing unit tests in SCXA
2 participants
@ke4 @lingyun1010