Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittently failing unit tests in SCXA #489

Closed
4 tasks done
ke4 opened this issue Nov 11, 2024 · 3 comments · Fixed by #491
Closed
4 tasks done

Intermittently failing unit tests in SCXA #489

ke4 opened this issue Nov 11, 2024 · 3 comments · Fixed by #491
Assignees
@ke4
Labels
bug Something isn't working

Comments

@ke4
Copy link
Contributor

ke4 commented Nov 11, 2024 •
edited
Loading

There are intermittently failing tests in our CI system:

There might be more. These are the ones I could collect for now.
We should fix them as soon as possible. It is not sustainable to rely on these tests successfully passing sometimes.
@ke4 ke4 added the bug Something isn't working label Nov 11, 2024
@ke4 ke4 linked a pull request Nov 12, 2024 that will close this issue
Fix the intermittently failing tests in SCXA #491
Merged
4 tasks
@ke4 ke4 self-assigned this Nov 15, 2024
@ke4
Copy link
Contributor Author

ke4 commented Nov 21, 2024 •
edited
Loading

Removed duplicated test from uk.ac.ebi.atlas.search.ToBeDeprecatedJsonGeneSearchControllerWIT.whenSearchTermExistsInDBThenReturnsSetOfCellType() in this commit: Remove all the duplicated tests that also presents in JsonGeneSearchC…

@ke4
Copy link
Contributor Author

ke4 commented Nov 21, 2024

Fix uk.ac.ebi.atlas.search.organismpart.OrganismPartSearchDaoIT.whenValidCellIdsAndValidCellTypesProvidedReturnSetOfOrganismPart() with this commit: Use exists method to filter out empty Solr documents

@ke4
Copy link
Contributor Author

ke4 commented Nov 25, 2024

Fix for uk.ac.ebi.atlas.search.celltype.CellTypeSearchDaoIT.whenValidCellIdsAndValidProvidedReturnSetOfCellTypes() with this commit: Fix CellTypeSearchDaoIT to filter for CTW_CELL_TYPE

@ke4 ke4 closed this as completed in #491 Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ke4 ke4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the intermittently failing tests in SCXA ebi-gene-expression-group/atlas-web-single-cell
1 participant
@ke4