Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatible with cxxopt. #171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −3
Open

compatible with cxxopt. #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
701f5c1
compatible with cxxopt.
xiaoxichen Apr 20, 2024
3f3ff73
Reduce #chunks to work around HS issue.
xiaoxichen Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomeObjectConan(ConanFile):
name = "homeobject"
version = "2.0.1"
version = "2.0.2"
homepage = "https://github.com/eBay/HomeObject"
description = "Blob Store built on HomeReplication"
topics = ("ebay")
Expand Down
4 changes: 3 additions & 1 deletion src/include/homeobject/homeobject.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ struct device_info_t {
friend std::istream& operator>>(std::istream& input, device_info_t& di) {
std::string i_path, i_type;
std::getline(input, i_path, ':');
std::getline(input, i_type);
if (input.peek() != EOF) {
std::getline(input, i_type);
}
di.path = std::filesystem::canonical(i_path);
if (i_type == "HDD") {
di.type = DevType::HDD;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/homestore_backend/hs_homeobject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ void HSHomeObject::init_homestore() {
{HS_SERVICE::REPLICATION,
hs_format_params{.dev_type = HSDevType::Data,
.size_pct = 99.0,
.num_chunks = 60000,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the intention here? why 32768?
can we specify the chunk_size and let homestore itself determine how many chunks will be created according to the disk space?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/eBay/HomeObject/pull/167/files#r1571091449
pls refer this discussion why specified chunk_size is less prefered.

Regarding the intent of move down to 32K , it is to work around the bug we are discussing in HS channel
https://ebay-eng.slack.com/archives/CAVQXEAKS/p1713889924523089

.num_chunks = 32768,
.block_size = _data_block_size,
.alloc_type = blk_allocator_type_t::append,
.chunk_sel_type = chunk_selector_type_t::CUSTOM}},
Expand Down
Loading