compatible with cxxopt. #171
Conversation
in https://github.com/jarro2783/cxxopts/blob/v3.2.1/include/cxxopts.hpp#L1011-L1018 it checks the (!in), if we read after reaching EOF, the !in will be true which results a incorrect_argument_type exception thrown. we should be very careful to avoid read after reaching eof. Signed-off-by: Xiaoxi Chen <[email protected]>
|
we are expecting However the later one doesnt work prior to this change , as we attempt to read post EOF for the type. Now SM has to pass With this PR merged, SM do not need pass-in the AUTO_DETECT |
HS report no availbe chunk after creating 44K chunks. which is under investigation. Signed-off-by: Xiaoxi Chen <[email protected]>
| @@ -170,7 +170,7 @@ void HSHomeObject::init_homestore() { | |||
| {HS_SERVICE::REPLICATION, | |||
| hs_format_params{.dev_type = HSDevType::Data, | |||
| .size_pct = 99.0, | |||
| .num_chunks = 60000, | |||
There was a problem hiding this comment.
what is the intention here? why 32768?
can we specify the chunk_size and let homestore itself determine how many chunks will be created according to the disk space?
There was a problem hiding this comment.
https://github.com/eBay/HomeObject/pull/167/files#r1571091449
pls refer this discussion why specified chunk_size is less prefered.
Regarding the intent of move down to 32K , it is to work around the bug we are discussing in HS channel
https://ebay-eng.slack.com/archives/CAVQXEAKS/p1713889924523089
in https://github.com/jarro2783/cxxopts/blob/v3.2.1/include/cxxopts.hpp#L1011-L1018
it checks the (!in), if we read after reaching EOF, the !in will be true which results a incorrect_argument_type exception thrown.
we should be very careful to avoid read after reaching eof.