Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: market close all #1031

Merged
merged 2 commits into from
Sep 27, 2024
Merged

feat: market close all #1031

merged 2 commits into from
Sep 27, 2024

Conversation

aforaleka
Copy link
Contributor

@aforaleka aforaleka commented Sep 17, 2024 •
edited
Loading

enable "close all" button on positions table that close all positions with market orders

  • the functionality is added to abacus, so FE only needs to call that function. market price = oracle price +/- slippage
  • it adds tracking similar to cancel all, so we can have a separate toast to keep count of number of positions closed. we'll still emit the fill notifications since they are relevant.
  • when a position isn't closed (i.e. order is canceled / not filled), we have a try again option

image
image
image

image
image
image

@vercel Vercel
Copy link

vercel bot commented Sep 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 6:11pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 6:11pm

@aforaleka aforaleka mentioned this pull request Sep 17, 2024
Merged
@aforaleka aforaleka changed the base branch from main to refactor-orders-state September 23, 2024 23:13
@aforaleka aforaleka force-pushed the refactor-orders-state branch from 4acaa90 to 123ab1c Compare September 24, 2024 18:35
Base automatically changed from refactor-orders-state to main September 24, 2024 21:17
@aforaleka aforaleka marked this pull request as ready for review September 25, 2024 20:27
@aforaleka aforaleka requested a review from a team as a code owner September 25, 2024 20:27
@aforaleka aforaleka enabled auto-merge (squash) September 26, 2024 21:53
@aforaleka aforaleka merged commit 34baa78 into main Sep 27, 2024
9 checks passed
@aforaleka aforaleka deleted the market-close-all branch September 27, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moo-onthelawn moo-onthelawn moo-onthelawn approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aforaleka @moo-onthelawn