feat: market close all positions #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aforaleka
force-pushed
the
market-close-all
branch
from
9d1b6a4 to
6c13025
Compare
prashanDYDX
reviewed
Sep 18, 2024
| @@ -268,6 +286,19 @@ internal class SubaccountTransactionPayloadProvider( | |||
| return HumanReadableTriggerOrdersPayload(marketId, positionSize, placeOrderPayloads, cancelOrderPayloads) | |||
| } | |||
|
|
|||
| private fun subaccountNumberForPosition(marketId: String): Int { | |||
There was a problem hiding this comment.
don't we have another helper for this somewhere already? @jaredvu
ruixhuang
previously approved these changes
Sep 18, 2024
aforaleka
force-pushed
the
market-close-all
branch
from
d2947b9 to
80f151b
Compare
ruixhuang
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a helper function to market close all open positions under parent subaccount 0
in the future when indexer supports mid price ws endpoint, and protocol support limit close (reduce-only non-IOC), we'll only add a limit close option. until then, this is just full closing all positions with market price (i.e. oracle price + slippage)
tested locally dydxprotocol/v4-web#1031