Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ohlc strings #622

Merged
merged 5 commits into from
Jul 24, 2024
+17 −4
Merged

ohlc strings #622

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f5d4c9
add strings
moo-onthelawn Jul 24, 2024
11419b1
1.1.163
moo-onthelawn Jul 24, 2024
d4ee55e
period
moo-onthelawn Jul 24, 2024
ee78f33
tooltips
moo-onthelawn Jul 24, 2024
820a46d
lint
moo-onthelawn Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/localization/en/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,6 +1326,9 @@
"NEXT_IN": "Next in {TIME}",
"NOTIONAL_VALUE": "Notional Value",
"OFFSETTING": "Offsetting",
"OHLC": "OHLC",
"OHLC_VIA_MID_PRICE": "OHLC (via mid-price)",
"OHLC_TOOLTIP": "Enable or disable OHLC data via mid-price. Disabling this will only display OHLC data from the orderbook.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aforaleka mentioned the tooltip should maybe be under the tooltip category

"OPEN_INTEREST": "Open Interest",
"OPEN_POSITIONS": "Open Positions",
"OPEN_STATUS": "Open",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dydxprotocol/v4-localization",
"version": "1.1.162",
"version": "1.1.163",
"description": "v4 localization",
"main": "index.ts",
"scripts": {
Expand Down
5 changes: 4 additions & 1 deletion scripts/generated/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// !! GENERATED FILE - DO NOT EDIT

// Generated from ../config/localization/en/app.json using codegen_localization_app.swift
// Generated from ../config/localization/en/app.json using ./codegen_localization_app.swift

export const APP_STRING_KEYS = {

Expand Down Expand Up @@ -1479,6 +1479,9 @@ export const APP_STRING_KEYS = {
NEXT_IN: 'APP.TRADE.NEXT_IN',
NOTIONAL_VALUE: 'APP.TRADE.NOTIONAL_VALUE',
OFFSETTING: 'APP.TRADE.OFFSETTING',
OHLC: 'APP.TRADE.OHLC',
OHLC_TOOLTIP: 'APP.TRADE.OHLC_TOOLTIP',
OHLC_VIA_MID_PRICE: 'APP.TRADE.OHLC_VIA_MID_PRICE',
OPEN_INTEREST: 'APP.TRADE.OPEN_INTEREST',
OPEN_POSITIONS: 'APP.TRADE.OPEN_POSITIONS',
OPEN_STATUS: 'APP.TRADE.OPEN_STATUS',
Expand Down
Loading