ohlc strings #622
Merged
ohlc strings #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
moo-onthelawn
commented
Jul 24, 2024
moo-onthelawn
commented
- add strings
- 1.1.163
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
config/localization/en/app.json
Outdated
| @@ -1326,6 +1326,9 @@ | |||
| "NEXT_IN": "Next in {TIME}", | |||
| "NOTIONAL_VALUE": "Notional Value", | |||
| "OFFSETTING": "Offsetting", | |||
| "OHLC": "OHLC", | |||
| "OHLC_VIA_MID_PRICE": "OHLC (via mid-price)", | |||
| "OHLC_TOOLTIP": "Enable or disable OHLC data via mid-price. Disabling this will only display OHLC data from the orderbook", | |||
There was a problem hiding this comment.
do we want a period at the end of this?
There was a problem hiding this comment.
hm our current tooltip on order lines doesn't have one so I thought it'd look more consistent if it didn't 🤔 // unsure if this is weirder because it's two sentences
There was a problem hiding this comment.
eh actually nah i feel like you're right, adding
yogurtandjam
approved these changes
Jul 24, 2024
config/localization/en/app.json
Outdated
| @@ -1326,6 +1326,9 @@ | |||
| "NEXT_IN": "Next in {TIME}", | |||
| "NOTIONAL_VALUE": "Notional Value", | |||
| "OFFSETTING": "Offsetting", | |||
| "OHLC": "OHLC", | |||
| "OHLC_VIA_MID_PRICE": "OHLC (via mid-price)", | |||
| "OHLC_TOOLTIP": "Enable or disable OHLC data via mid-price. Disabling this will only display OHLC data from the orderbook.", | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.