Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Notification option strings #148

Merged
merged 3 commits into from
Nov 7, 2023
+16 −6
Merged

Push Notification option strings #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bd1db7
Add strings for Push Notifs and Transfer Notifs
jaredvu Nov 7, 2023
2c4d532
Merge branch 'main' into notification-strings
jaredvu Nov 7, 2023
f7b94ea
bump 1.0.4
jaredvu Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions config/localization/en/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
"CATEGORY": "Category",
"CHAINS": "Chains",
"CLEAR": "Clear",
"CLEAR_ALL": "Clear All",
"CLICK_HERE": "Click here",
"CLOSE": "Close",
"COMING_SOON": "Coming soon",
Expand Down Expand Up @@ -657,8 +658,9 @@
"COULD_NOT_FIND_AFFILIATE": "We couldn't find this affiliate, please check the link.",
"CREATE_OR_VERIFY_COSMOS_ADDRESS": "Create or verify Cosmos address.",
"CREDITED_WITH": "Your account will be credited with ${AMOUNT_USD} in test funds.",
"DEPOSIT_STATUS": "Your deposit of {AMOUNT_USD} will be available in approximately {ESTIMATED_DURATION}.",
"DEPOSIT_OF": "Deposit of {AMOUNT_USD}",
"DEPOSIT_COMPLETE": "Your deposit of {AMOUNT_USD} is now available.",
"DEPOSIT_STATUS": "Your deposit of {AMOUNT_USD} will be available in approximately {ESTIMATED_DURATION}.",
"DONT_MISS": "Don't miss your chance to get a {DISCOUNT} on trading fees!",
"ENABLE_API": "Enable secure access to our API for lightning quick trading",
"ENABLE_TRADING": "Enable trading",
Expand Down Expand Up @@ -728,8 +730,9 @@
"WANT_TO_LEARN": "Want to learn more?",
"WELCOME_DYDX": "Welcome to dYdX",
"WELCOME": "Welcome",
"WITHDRAW_STATUS": "Your withdrawal of {AMOUNT_USD} will be available in approximately {ESTIMATED_DURATION}.",
"WITHDRAW_COMPLETE": "Your withdrawal of {AMOUNT_USD} is now available.",
"WITHDRAW_OF": "Withdraw of {AMOUNT_USD}",
"WITHDRAW_STATUS": "Your withdrawal of {AMOUNT_USD} will be available in approximately {ESTIMATED_DURATION}.",
"WRONG_NETWORK_EXPLANATION_PRODUCTION": "To complete dYdX onboarding, set your wallet network to 'Ethereum Mainnet'.",
"WRONG_NETWORK_EXPLANATION_STAGING": "To complete dYdX onboarding, set your wallet network to 'Goerli Test Network'.",
"WRONG_NETWORK": "Wrong network",
Expand Down Expand Up @@ -1230,6 +1233,8 @@
"DEPOSIT_SUCCESS": "Deposit success!",
"DIRECT_TRANSFER_SUCCESS": "Direct transfer success!",
"DIRECT_TRANSFER_SUCCESS_DESCRIPTION": "Your direct transfer of {AMOUNT_ELEMENT} has been confirmed.",
"DISABLE_PUSH_NOTIFICATIONS": "Disable Push Notifications",
"ENABLE_PUSH_NOTIFICATIONS": "Enable Push Notifications",
Comment on lines +1236 to +1237
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "Disable push notifications" vs "Disable Push Notifications"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think capitalized should be okay. Can change in the future.

"EPOCH_REWARDS": "Epoch {EPOCH_NUMBER} Rewards",
"EPOCH_REWARDS_BODY": "You earned {DYDX} $DYDX rewards during Epoch {EPOCH_NUMBER}!",
"FAST_WITHDRAW_PENDING_DESCRIPTION": "Your fast withdraw of {AMOUNT_ELEMENT} is pending confirmation on Layer 1.",
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@dydxprotocol/v4-localization",
"version": "1.0.3",
"version": "1.0.4",
"description": "v4 localization",
"main": "index.ts",
"scripts": {
Expand Down
7 changes: 6 additions & 1 deletion scripts/generated/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// !! GENERATED FILE - DO NOT EDIT

// Generated from ../config/localization/en/app.json using ./codegen_localization_app.swift
// Generated from ../config/localization/en/app.json using codegen_localization_app.swift

export const APP_STRING_KEYS = {

Expand Down Expand Up @@ -332,6 +332,7 @@ export const APP_STRING_KEYS = {
CATEGORY: 'APP.GENERAL.CATEGORY',
CHAINS: 'APP.GENERAL.CHAINS',
CLEAR: 'APP.GENERAL.CLEAR',
CLEAR_ALL: 'APP.GENERAL.CLEAR_ALL',
CLICK_HERE: 'APP.GENERAL.CLICK_HERE',
CLOSE: 'APP.GENERAL.CLOSE',
COMING_SOON: 'APP.GENERAL.COMING_SOON',
Expand Down Expand Up @@ -757,6 +758,8 @@ export const APP_STRING_KEYS = {
DEPOSIT_SUCCESS_DESCRIPTION: 'APP.NOTIFICATIONS.DEPOSIT_SUCCESS_DESCRIPTION',
DIRECT_TRANSFER_SUCCESS: 'APP.NOTIFICATIONS.DIRECT_TRANSFER_SUCCESS',
DIRECT_TRANSFER_SUCCESS_DESCRIPTION: 'APP.NOTIFICATIONS.DIRECT_TRANSFER_SUCCESS_DESCRIPTION',
DISABLE_PUSH_NOTIFICATIONS: 'APP.NOTIFICATIONS.DISABLE_PUSH_NOTIFICATIONS',
ENABLE_PUSH_NOTIFICATIONS: 'APP.NOTIFICATIONS.ENABLE_PUSH_NOTIFICATIONS',
EPOCH_REWARDS: 'APP.NOTIFICATIONS.EPOCH_REWARDS',
EPOCH_REWARDS_BODY: 'APP.NOTIFICATIONS.EPOCH_REWARDS_BODY',
FAST_WITHDRAW_PENDING: 'APP.NOTIFICATIONS.FAST_WITHDRAW_PENDING',
Expand Down Expand Up @@ -815,6 +818,7 @@ export const APP_STRING_KEYS = {
DEPOSIT_ALERT_SUBTITLE: 'APP.ONBOARDING.DEPOSIT_ALERT_SUBTITLE',
DEPOSIT_ALERT_TITLE: 'APP.ONBOARDING.DEPOSIT_ALERT_TITLE',
DEPOSIT_COMPLETE: 'APP.ONBOARDING.DEPOSIT_COMPLETE',
DEPOSIT_OF: 'APP.ONBOARDING.DEPOSIT_OF',
DEPOSIT_STATUS: 'APP.ONBOARDING.DEPOSIT_STATUS',
DEPOSIT_TO_DESTINATION: 'APP.ONBOARDING.DEPOSIT_TO_DESTINATION',
DEPOSIT_TO_DYDX: 'APP.ONBOARDING.DEPOSIT_TO_DYDX',
Expand Down Expand Up @@ -901,6 +905,7 @@ export const APP_STRING_KEYS = {
WITHDRAWAL_ALERT_SUBTITLE: 'APP.ONBOARDING.WITHDRAWAL_ALERT_SUBTITLE',
WITHDRAWAL_ALERT_TITLE: 'APP.ONBOARDING.WITHDRAWAL_ALERT_TITLE',
WITHDRAW_COMPLETE: 'APP.ONBOARDING.WITHDRAW_COMPLETE',
WITHDRAW_OF: 'APP.ONBOARDING.WITHDRAW_OF',
WITHDRAW_STATUS: 'APP.ONBOARDING.WITHDRAW_STATUS',
WRONG_NETWORK: 'APP.ONBOARDING.WRONG_NETWORK',
WRONG_NETWORK_EXPLANATION_PRODUCTION: 'APP.ONBOARDING.WRONG_NETWORK_EXPLANATION_PRODUCTION',
Expand Down