Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Notification option strings #148

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Push Notification option strings #148

merged 3 commits into from
Nov 7, 2023

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Nov 7, 2023

No description provided.

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-localization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 7:01pm

Comment on lines +1236 to +1237
"DISABLE_PUSH_NOTIFICATIONS": "Disable Push Notifications",
"ENABLE_PUSH_NOTIFICATIONS": "Enable Push Notifications",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be "Disable push notifications" vs "Disable Push Notifications"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think capitalized should be okay. Can change in the future.

@jaredvu jaredvu merged commit 453a55e into main Nov 7, 2023
2 checks passed
@jaredvu jaredvu deleted the notification-strings branch November 7, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants