Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS QuickType support update #3648

Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 7, 2024

Task/Issue URL:
Tech Design URL:
CC:

Description:

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Confirm CI is green

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Copy link
Contributor

github-actions bot commented Dec 7, 2024

Fails
🚫 Please, don't forget to add a link to the internal task

Generated by 🚫 dangerJS against 3cdc24c

@amddg44 amddg44 marked this pull request as ready for review December 9, 2024 10:36
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 on green CI

amddg44 added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Dec 9, 2024
Task/Issue URL: 
iOS PR: duckduckgo/iOS#3696
macOS PR: duckduckgo/macos-browser#3648
What kind of version bump will this require?: Minor

**Description**:
Adds support for QuickType to the Credential provider extension along
with deduplication logic
@amddg44 amddg44 merged commit 2cd5466 into anya/ios-system-cred-provider Dec 9, 2024
25 of 27 checks passed
@amddg44 amddg44 deleted the anya/ios-quicktype-support-update branch December 9, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants