-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QuickType support for iOS #1123
Merged
amddg44
merged 11 commits into
feature/system-credential-provider
from
anya/quicktype-support
Dec 9, 2024
Merged
QuickType support for iOS #1123
amddg44
merged 11 commits into
feature/system-credential-provider
from
anya/quicktype-support
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arksProvider) providing list of incoming data changes to allow QuickType store to be updated
…nts with multiple different domains
amddg44
changed the base branch from
main
to
feature/system-credential-provider
December 7, 2024 17:40
aataraxiaa
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor suggestions @amddg44. Nice tests 👍🏼
Sources/BrowserServicesKit/SecureVault/AutofillCredentialIdentityStoreManager.swift
Outdated
Show resolved
Hide resolved
Sources/BrowserServicesKit/SecureVault/AutofillCredentialIdentityStoreManager.swift
Outdated
Show resolved
Hide resolved
Sources/BrowserServicesKit/SecureVault/AutofillCredentialIdentityStoreManager.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL:
iOS PR: duckduckgo/iOS#3696
macOS PR: duckduckgo/macos-browser#3648
What kind of version bump will this require?: Minor
Description:
Adds support for QuickType to the Credential provider extension along with deduplication logic
Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template