Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickType support for iOS #1123

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 7, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL:
iOS PR: duckduckgo/iOS#3696
macOS PR: duckduckgo/macos-browser#3648
What kind of version bump will this require?: Minor

Description:
Adds support for QuickType to the Credential provider extension along with deduplication logic

Steps to test this PR:

  1. See client PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the base branch from main to feature/system-credential-provider December 7, 2024 17:40
@amddg44 amddg44 marked this pull request as ready for review December 9, 2024 10:33
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions @amddg44. Nice tests 👍🏼

@amddg44 amddg44 merged commit a374b64 into feature/system-credential-provider Dec 9, 2024
7 checks passed
@amddg44 amddg44 deleted the anya/quicktype-support branch December 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants