Privacy Pro Free Trials - Models and API #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
miasma13
approved these changes
Dec 11, 2024
aataraxiaa
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 11, 2024
Task/Issue URL: https://app.asana.com/0/1208114992212396/1208796999534221/f iOS PR: duckduckgo/iOS#3691 macOS PR: duckduckgo/macos-browser#3641 What kind of version bump will this require?: Minor **Optional**: Tech Design URL: https://app.asana.com/0/481882893211075/1208773437150501/f **Description**: This PR includes the following: * Adds a new model type for Subscription Offers * Adds a new API to `StorePurchaseManager` to retrieve Free Trial Subscriptions * Updates existing `subscriptionOptions` API to NOT return Free Trial Subscriptions * Adds abstractions on StoreKit types to enable testing * Adds tests (**Note: Make sure to expand the `StorePurchaseManagerTests` file when reviewing**)
aataraxiaa
force-pushed
the
pete/pp-free-trials-offer-models
branch
from
b6cd7f0 to
ab5e6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1208114992212396/1208796999534221/f
Tech Design URL: https://app.asana.com/0/481882893211075/1208773437150501/f
Description: Includes the following changes:
SubscriptionProducttype toProducttype, but only in debug menu codeSteps to test this PR:
Definition of Done (Internal Only):
Internal references:
Software Engineering Expectations
Technical Design Template
?
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation