Privacy Pro Free Trials - Models and API #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Decorate SubscriptionOption with Free Trial info. Abstract StoreKit types to enabled testing. Add tests.
This was referenced Dec 6, 2024
miasma13
reviewed
Dec 11, 2024
| @@ -34,10 +34,157 @@ public enum StorePurchaseManagerError: Error { | |||
| case unknownError | |||
| } | |||
|
|
|||
| /// A protocol that defines the properties of an introductory offer for a subscription product. | |||
There was a problem hiding this comment.
Since this file gets a bit bloated and may be a bit hard to wrap your head around, what do you think about making a StorePurchaseManager subfolder and split out the protocols, extensions etc. to separate files?
There was a problem hiding this comment.
Good suggestion @miasma13, I'll make that change.
miasma13
approved these changes
Dec 11, 2024
aataraxiaa
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Dec 11, 2024
Task/Issue URL: https://app.asana.com/0/1208114992212396/1208796999534221/f Tech Design URL: https://app.asana.com/0/481882893211075/1208773437150501/f **Description**: Includes the following changes: * Bumps BSK which includes changes [here]. (duckduckgo/BrowserServicesKit#1120) * Also forces casts `SubscriptionProduct` type to `Product` type, but only in debug menu code
aataraxiaa
added a commit
to duckduckgo/iOS
that referenced
this pull request
Dec 11, 2024
Task/Issue URL: https://app.asana.com/0/1208114992212396/1208796999534221/f Tech Design URL: https://app.asana.com/0/481882893211075/1208773437150501/f **Description**: Bumps BSK which includes changes [here](duckduckgo/BrowserServicesKit#1120)
samsymons
added a commit
that referenced
this pull request
Dec 19, 2024
* main: (24 commits) change api (#1133) Ensure authToken is present before calling refreshAuthTokenIfNeeded Add 'locale' to report broken site params Add 'locale' to report broken site params Ensure authToken is present before calling refreshAuthTokenIfNeeded Privacy Pro Free Trials - Models and API (#1120) remove MaliciousSiteProtectionSubfeature (#1131) Malware protection 6: Malware integration (#1099) Add underlying error to PrivacyStatsError (#1130) Initial changes for compilation time tracking. (#1111) iOS System level credential provider (#1127) Increase ratio of complete form saves (#1124) Add PrivacyStatsError.failedToClearPrivacyStats (#1128) Update autofill to 16.0.0 (#1122) Update local network routing (#1117) Update RMF version matching to ignore build number (#1118) Fix threading issue between using a Semaphore and async/await (#1115) add experiment test fake feature (#1119) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `a603ff9` to `6133e7d` (#1109) experiment default metrics pixels (#1107) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1208114992212396/1208796999534221/f
iOS PR: duckduckgo/iOS#3691
macOS PR: duckduckgo/macos-browser#3641
What kind of version bump will this require?: Minor
Optional:
Tech Design URL: https://app.asana.com/0/481882893211075/1208773437150501/f
Description: This PR includes the following:
StorePurchaseManagerto retrieve Free Trial SubscriptionssubscriptionOptionsAPI to NOT return Free Trial SubscriptionsStorePurchaseManagerTestsfile when reviewing)Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template