Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visted links support #3261

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Add visted links support #3261

merged 6 commits into from
Sep 13, 2024

Conversation

mallexxx
Copy link
Collaborator

@mallexxx mallexxx commented Sep 12, 2024

Task/Issue URL: https://app.asana.com/0/1175293949586521/1204211850543327/f
BSK PR: duckduckgo/BrowserServicesKit#992
iOS PR: duckduckgo/iOS#3353

Description:

  • Activates visited links support

Steps to test this PR:

  1. Open SERP; open some links in same tab; in new tab – validate links are colored with purple
  2. Duplicate the SERP tab, validate the purple links stay
  3. Open Fire Window with the same SERP; validate the links aren't colored
  4. Validate burning (all/tab/only domains) removes the visited links

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@mallexxx mallexxx requested review from a team and dus7 and removed request for a team and dus7 September 12, 2024 09:06
@ayoy ayoy self-assigned this Sep 12, 2024
@ayoy ayoy self-requested a review September 13, 2024 06:23
Copy link
Collaborator

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great! I verified that visited links are susceptible to fire as expected 👍 thanks @mallexxx!

@ayoy ayoy assigned mallexxx and unassigned ayoy Sep 13, 2024
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Sep 13, 2024
@mallexxx mallexxx merged commit 5c141ba into main Sep 13, 2024
19 checks passed
@mallexxx mallexxx deleted the alex/visited-links branch September 13, 2024 08:57
samsymons added a commit that referenced this pull request Sep 13, 2024
# By Dominik Kapusta (7) and others
# Via Dominik Kapusta (6) and GitHub (4)
* main: (37 commits)
  Add visted links support (#3261)
  Bump version to 1.106.0 (261)
  Update Gemfile.lock
  Remove migration file (#3270)
  Use new AsanaCreateActionItem action (#3264)
  Update survey builder OS version (#3247)
  Support dragging strings to new tab button (#3228)
  BSK - Add feature flag for SKAN API (#3265)
  Ignore accents when doing a bookmark search (#3255)
  Update UI tests workflows to always compile the app on the supported version of Xcode (#3262)
  Bump C.S.S (via BSK) (#3244)
  Tab previews presentation implementation adjusted for the latest MouseOverView logic (#3260)
  Bump version to 1.106.0 (260)
  Default to appstore signing for fastlane match
  Clean up secrets in GHA workflows
  Update Onboarding gradients (#3248)
  Wait for UserScripts to be loaded for email protection (#3252)
  Fix UI tests failing in the CI (#3254)
  Fix WKDownloadMock mock (#3258)
  VPN Proxy stop and pixel improvements (#3239)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants