Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for macOS: visited links #3353

Merged
merged 3 commits into from
Sep 13, 2024
Merged

update for macOS: visited links #3353

merged 3 commits into from
Sep 13, 2024

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1175293949586521/1204211850543327/f
BSK PR: duckduckgo/BrowserServicesKit#992
macOS PR: duckduckgo/macos-browser#3261
Tech Design URL:
CC:

Description:

  • return visited URLs when burning history records by domain

Steps to test this PR:

  1. Validate build works

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy assigned mallexxx and unassigned ayoy Sep 13, 2024
mallexxx added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Sep 13, 2024
@mallexxx mallexxx merged commit d5d9fbe into main Sep 13, 2024
13 checks passed
@mallexxx mallexxx deleted the alex/macos-visited-links branch September 13, 2024 08:14
mallexxx added a commit to duckduckgo/macos-browser that referenced this pull request Sep 13, 2024
samsymons added a commit that referenced this pull request Sep 13, 2024
# By Alessandro Boron (7) and others
# Via Bartek Waresiak (1) and others
* main: (31 commits)
  Add Marketplace Postback handling (#3357)
  SKAD4 crash fix (#3361)
  Enroll all internal users in experiment && Update BSK (#3359)
  update for macOS: visited links (#3353)
  Ensure toast closures are called on the main thread (#3347)
  Update survey builder OS version (#3348)
  BSK - Add feature flag for SKAN API (#3356)
  Remove checking for negative attribution case  (#3355)
  C.S.S Bump (Via BSK) (#3346)
  Update Onboarding gradients (#3350)
  Alessandro/onboarding copy and private search options (#3349)
  Onboarding Intro - Add choose address bar position (#3340)
  Fix PrivacyDashboard appearance on entering foreground (#3345)
  Improve Data Store ID managing (#3335)
  Alessandro/onboarding choose app icon (#3330)
  Fix Localizable strings (#3341)
  Move lazy var access to the MainActor (#3333)
  Release 7.137.0-2 (#3344)
  Fix privacy icon glitch (#3343)
  BSK bump for macOS password import promotion flow (#3332)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Sep 16, 2024
* main:
  Remove VPN feature flag checks (#3334)
  Add Marketplace Postback handling (#3357)
  SKAD4 crash fix (#3361)
  Enroll all internal users in experiment && Update BSK (#3359)
  update for macOS: visited links (#3353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants