Promote password import in autofill menu #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
amddg44
approved these changes
Sep 6, 2024
|
@amddg44 Just for posterity the bug you mentioned was already fixed in autofill.js and is in the 13.1.0 version (Release Candidate) So we should be already good with the tagged version :) |
graeme
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Sep 10, 2024
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/72649045549333/1207617229892922/f iOS PR: duckduckgo/iOS#3332 macOS PR: duckduckgo/macos-browser#3220 What kind of version bump will this require?: Major **Optional**: Tech Design URL: https://app.asana.com/0/481882893211075/1208037181667142 **Description**: When adopting a new browser after a long time using something else, you expect your browser to have all your data. If you skipped import during onboarding you will find out about the missing data at the time when you're trying to use the password. This creates huge friction right in the middle of a task. See [Comment by Peter Dolanjski on Password and autofill issues](https://app.asana.com/0/0/1207533847538452/1207544369978642/f). Reminding users of the option to import right when that friction happens could be a way to quickly give recourse and solve the problem for all subsequent browsing needs. This feature promotes the import in autofill scenarios when the user has few or no passwords saved. **Steps to test this PR**: (Same as macOS PR) https://app.asana.com/0/72649045549333/1208245520043990/f **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
…rd-import-in-autofill-menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207617229892922/f
BSK PR: duckduckgo/BrowserServicesKit#976
Description:
When adopting a new browser after a long time using something else, you expect your browser to have all your data. If you skipped import during onboarding you will find out about the missing data at the time when you're trying to use the password. This creates huge friction right in the middle of a task. See Comment by Peter Dolanjski on Password and autofill issues.
Reminding users of the option to import right when that friction happens could be a way to quickly give recourse and solve the problem for all subsequent browsing needs.
This feature promotes the import in autofill scenarios when the user has few or no passwords saved.
Steps to test this PR:
https://app.asana.com/0/72649045549333/1208245520043990/f
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation