Promote password import in autofill menu #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
changed the title
…rd-import-in-autofill-menu
1 task
amddg44
approved these changes
Sep 6, 2024
Sources/BrowserServicesKit/Autofill/AutofillUserScript+SecureVault.swift
Show resolved
Hide resolved
graeme
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 10, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1207617229892922/f BSK PR: duckduckgo/BrowserServicesKit#976 **Description**: When adopting a new browser after a long time using something else, you expect your browser to have all your data. If you skipped import during onboarding you will find out about the missing data at the time when you're trying to use the password. This creates huge friction right in the middle of a task. See [Comment by Peter Dolanjski on Password and autofill issues](https://app.asana.com/0/0/1207533847538452/1207544369978642/f). Reminding users of the option to import right when that friction happens could be a way to quickly give recourse and solve the problem for all subsequent browsing needs. This feature promotes the import in autofill scenarios when the user has few or no passwords saved. **Steps to test this PR**: https://app.asana.com/0/72649045549333/1208245520043990/f **Definition of Done**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Revert "C.S.S Patch Privacy Config on C.S.S for "internal" support in… (#995) C.S.S Patch Privacy Config on C.S.S for "internal" support in DuckPlayer (#994) return urls on burn domains (#992) Update survey builder OS version (#984) Add feature flag for SKAN API (#993) [DuckPlayer] Add feature flag and update C.S.S (#983) Update Onboarding gradients (#985) Fix WKDownload cancellation under Xcode 16 (#986) Add shouldCheckServerTrust flag (#982) Promote password import in autofill menu (#976) Add Phishing Detection Feature (#981) Revert "Add Phishing Detection Package" (#980) Add Phishing Detection Package (#935) Update VPN user agent (#971) New feature flag for autofillSurveys (#974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1207617229892922/f
iOS PR: duckduckgo/iOS#3332
macOS PR: duckduckgo/macos-browser#3220
What kind of version bump will this require?: Major
Optional:
Tech Design URL: https://app.asana.com/0/481882893211075/1208037181667142
Description:
When adopting a new browser after a long time using something else, you expect your browser to have all your data. If you skipped import during onboarding you will find out about the missing data at the time when you're trying to use the password. This creates huge friction right in the middle of a task. See Comment by Peter Dolanjski on Password and autofill issues.
Reminding users of the option to import right when that friction happens could be a way to quickly give recourse and solve the problem for all subsequent browsing needs.
This feature promotes the import in autofill scenarios when the user has few or no passwords saved.
Steps to test this PR:
(Same as macOS PR) https://app.asana.com/0/72649045549333/1208245520043990/f
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template