Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add connection tester failure pixels #2948

Merged
merged 8 commits into from
Jul 6, 2024
Merged

Add connection tester failure pixels #2948

merged 8 commits into from
Jul 6, 2024

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Jul 5, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

iOS PR: duckduckgo/iOS#3049
BSK PR: duckduckgo/BrowserServicesKit#881

Description

Adds pixels to track connection tester failures and recovery. These should give us a better idea about how users are faring.

Testing

  1. Download the ruleset.txt file to your desktop
  2. Start the VPN.
  3. Check that it works.
  4. Run the command: sudo pfctl -ef ~/Desktop/ruleset.txt
  5. It can take up to 15 seconds for the first pixels to show:
👾[Daily and Count-Fired] m_mac_netp_connection_tester_failure_d ["appVersion": "1.95.0", "pixelSource": "vpnSystemExtension"]
👾[Daily and Count-Fired] m_mac_netp_connection_tester_failure_c ["appVersion": "1.95.0", "pixelSource": "vpnSystemExtension"]
  1. Then wait another 2-4 mins and you should see the extended failure (please not that it sometimes take much longer probably because the timer isn't very reliable which is fine):
👾[Daily and Count-Fired] m_mac_netp_connection_tester_extended_failure_d ["appVersion": "1.95.0", "pixelSource": "vpnSystemExtension"]
👾[Daily and Count-Fired] m_mac_netp_connection_tester_extended_failure_c ["appVersion": "1.95.0", "pixelSource": "vpnSystemExtension"]
  1. Once you see that, run the CLI terminal command sudo pfctl -d
  2. You should see the following pixels:
👾[Daily and Count-Fired] m_mac_netp_connection_tester_failure_recovered_d ["pixelSource": "vpnSystemExtension", "appVersion": "1.95.0", "count": "8"]
👾[Daily and Count-Fired] m_mac_netp_connection_tester_failure_recovered_c ["count": "8", "pixelSource": "vpnSystemExtension", "appVersion": "1.95.0"]
👾[Daily and Count-Fired] m_mac_netp_connection_tester_extended_failure_recovered_d ["pixelSource": "vpnSystemExtension", "appVersion": "1.95.0", "count": "8"]
👾[Daily and Count-Fired] m_mac_netp_connection_tester_extended_failure_recovered_c ["appVersion": "1.95.0", "pixelSource": "vpnSystemExtension", "count": "8"]

Definition of Done:

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@diegoreymendez diegoreymendez self-assigned this Jul 5, 2024
This was referenced Jul 5, 2024
Merged
Merged
@diegoreymendez diegoreymendez marked this pull request as ready for review July 5, 2024 14:54
diegoreymendez
diegoreymendez commented Jul 5, 2024
View reviewed changes
...workProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift Outdated
@@ -154,6 +154,39 @@ final class MacPacketTunnelProvider: PacketTunnelProvider {
frequency: .legacyDaily,
withAdditionalParameters: [PixelKit.Parameters.vpnCohort: PixelKit.cohort(from: defaults.vpnFirstEnabled)],
includeAppVersionParameter: true)
case .connectionTesterStatusChange(let status):
vpnLogger.log(status)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also log these.

diegoreymendez added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 6, 2024
@diegoreymendez
Add connection tester failure pixels (#881)
0746af0 
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

iOS PR: duckduckgo/iOS#3049
macOS PR: duckduckgo/macos-browser#2948

What kind of version bump will this require?: Patch

## Description

Adds pixels to track connection tester failures and recovery.  These should give us a better idea about how users are faring.
diegoreymendez added a commit to duckduckgo/iOS that referenced this pull request Jul 6, 2024
@diegoreymendez
Add connection tester failure pixels (#3049)
094fdf3 
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

macOS PR: duckduckgo/macos-browser#2948
BSK PR: duckduckgo/BrowserServicesKit#881

## Description

Adds pixels to track connection tester failures and recovery.  These should give us a better idea about how users are faring.
@diegoreymendez diegoreymendez merged commit 5915175 into main Jul 6, 2024
19 checks passed
@diegoreymendez diegoreymendez deleted the diego/pixel-tunnel-down branch July 6, 2024 12:32
mgurgel pushed a commit to duckduckgo/BrowserServicesKit that referenced this pull request Jul 8, 2024
@diegoreymendez @mgurgel
Add connection tester failure pixels (#881)
1c81413 
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f

iOS PR: duckduckgo/iOS#3049
macOS PR: duckduckgo/macos-browser#2948

What kind of version bump will this require?: Patch

## Description

Adds pixels to track connection tester failures and recovery.  These should give us a better idea about how users are faring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quanganhdo quanganhdo quanganhdo approved these changes

@samsymons samsymons Awaiting requested review from samsymons

Assignees

@diegoreymendez diegoreymendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoreymendez @quanganhdo