Add connection tester failure pixels #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
1 task
diegoreymendez
commented
Jul 5, 2024
| @@ -267,9 +267,8 @@ final class NetworkProtectionConnectionTester { | |||
| if failureCount == 0 { | |||
| resultHandler(.connected) | |||
| } else if failureCount > 0 { | |||
| resultHandler(.reconnected(failureCount: failureCount)) | |||
There was a problem hiding this comment.
We want to know how many failures there were before recovery, as we want to send different recovery pixels depending on it.
diegoreymendez
commented
Jul 5, 2024
| providerEvents.fire(.connectionTesterStatusChange(.recovered(duration: .immediate, failureCount: failureCount))) | ||
|
|
||
| if failureCount >= 8 { | ||
| providerEvents.fire(.connectionTesterStatusChange(.recovered(duration: .extended, failureCount: failureCount))) |
There was a problem hiding this comment.
Being able to see if users are seeing failures for more than a couple of minutes is good because we want to see if there's a need to offer some form of manual recovery for this case. This is information that can give us something actionable.
quanganhdo
approved these changes
Jul 5, 2024
quanganhdo
reviewed
Jul 5, 2024
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Jul 6, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f macOS PR: duckduckgo/macos-browser#2948 BSK PR: duckduckgo/BrowserServicesKit#881 ## Description Adds pixels to track connection tester failures and recovery. These should give us a better idea about how users are faring.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Jul 6, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f iOS PR: duckduckgo/iOS#3049 BSK PR: duckduckgo/BrowserServicesKit#881 ## Description Adds pixels to track connection tester failures and recovery. These should give us a better idea about how users are faring.
samsymons
added a commit
that referenced
this pull request
Jul 7, 2024
# By Diego Rey Mendez (2) and others # Via Diego Rey Mendez (1) and GitHub (1) * main: Add connection tester failure pixels (#881) De-duplicate passwords on import (#869) Privacy Dashboard refactor (#879) Improve VPN logging logic (#877) Subscription refactoring #5 (#874) Fixes for Xcode16 (#864) Update the Privacy Pro status attribute to use an array. (#878) # Conflicts: # Sources/NetworkProtection/PacketTunnelProvider.swift
mgurgel
pushed a commit
that referenced
this pull request
Jul 8, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f iOS PR: duckduckgo/iOS#3049 macOS PR: duckduckgo/macos-browser#2948 What kind of version bump will this require?: Patch ## Description Adds pixels to track connection tester failures and recovery. These should give us a better idea about how users are faring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207743877093953/f
iOS PR: duckduckgo/iOS#3049
macOS PR: duckduckgo/macos-browser#2948
What kind of version bump will this require?: Patch
Description
Adds pixels to track connection tester failures and recovery. These should give us a better idea about how users are faring.
Testing
See the platform-specific PRs for instructions.
Internal references:
Software Engineering Expectations
Technical Design Template