DBP: Enable DBP Operations to Run When Device is Locked #2797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bot: not in app board
6 tasks
aataraxiaa
removed
the
bot: not in app board
…n, slightly improve implementation
I have bad news, this is what greeted me when I opened my laptop back up. I'm not sure why yet. It wasn't plugged in, so maybe that's why, I'll try again. It did continue at least
|
THISISDINOSAUR
approved these changes
May 21, 2024
| @@ -18,7 +18,11 @@ | |||
|
|
|||
| import Foundation | |||
|
|
|||
| extension Bundle { | |||
| protocol GroupNameProviding { | |||
There was a problem hiding this comment.
This was very inevitable 😅
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # LocalPackages/DataBrokerProtection/Package.swift # LocalPackages/NetworkProtectionMac/Package.swift # LocalPackages/SubscriptionUI/Package.swift
samsymons
added a commit
that referenced
this pull request
Jun 4, 2024
* main: Add optional "multiple" property to PageElement (#2827) Update BSK for iOS RMF changes (#2831) Bump version to 1.91.0 (197) Set marketing version to 1.91.0 Update embedded files DBP: Enable DBP Operations to Run When Device is Locked (#2797) Update autoconsent to v10.9.0 (#2822) Bump version to 1.90.0 (196) Revert "Add PIPAgent entitlement (#2821)" (#2823) Bump version to 1.90.0 (195) Bump version to 1.90.0 (194) Add PIPAgent entitlement (#2821) Fixes some VPN uninstallation issues (#2820) Bump version to 1.90.0 (193) Remove autofill survey (#2819)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206488453854252/1206891169830209/f
Tech Design URL: https://app.asana.com/0/1206488453854252/1207313481959835/f
Description:
This PR changes the accessibility attribute of DBP Keychain items to enable them to be accessed when the device is locked. It also migrates Keychain values for existing DBP users.
** Testing Pre-requisites **
Steps to test this PR:
Ensure Keychain Migration Works & Existing Data Is Retained
mainbuildEnsure Scans Work
Ensure Scans Work When Device is Locked/Sleeping
Note: Device should be plugged in, and left for an hour or more (during lunch, after work etc.)
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation