Enable DBP Keychain Item Accessibility Migration #827
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1206488453854252/1206891169830209/f
iOS PR: duckduckgo/iOS#2877
macOS PR: duckduckgo/macos-browser#2797
What kind of version bump will this require?: Major
Optional:
Tech Design URL: https://app.asana.com/0/1206488453854252/1207313481959835/f
CC:
Description:
PR includes changes relating to migrating DBP Keychain data to enable access when the device is locked. Specifically, this PR:
update
method to theKeychainService
protocol, with a default implementationkeychainAccessibilityValue
var to theSecureStorageKeyStoreProvider
protocol, with a default implementationwriteData
method to utilizekeychainAccessibilityValue
SecureStorageError
cases -keystoreReadError
andkeystoreUpdateError
AutofillKeyStoreProvider
test to ensure the correctkeychainAccessibilityValue
is usedSteps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template