Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DBP Keychain Item Accessibility Migration #827

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

aataraxiaa
Copy link
Contributor

@aataraxiaa aataraxiaa commented May 20, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1206488453854252/1206891169830209/f
iOS PR: duckduckgo/iOS#2877
macOS PR: duckduckgo/macos-browser#2797
What kind of version bump will this require?: Major

Optional:

Tech Design URL: https://app.asana.com/0/1206488453854252/1207313481959835/f
CC:

Description:
PR includes changes relating to migrating DBP Keychain data to enable access when the device is locked. Specifically, this PR:

  • Adds an update method to the KeychainService protocol, with a default implementation
  • Adds a keychainAccessibilityValue var to the SecureStorageKeyStoreProvider protocol, with a default implementation
  • Updates the writeData method to utilize keychainAccessibilityValue
  • Adds two new SecureStorageError cases - keystoreReadError and keystoreUpdateError
  • Adds a AutofillKeyStoreProvider test to ensure the correct keychainAccessibilityValue is used

Steps to test this PR:

  1. See Test Cases on related macOS and iOS PRs

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@aataraxiaa aataraxiaa changed the title Pete/dbp locked keychain access and migration Enable DBP Keychain Item Accessibility Migration May 20, 2024
@aataraxiaa aataraxiaa requested a review from THISISDINOSAUR May 20, 2024 16:41
@aataraxiaa aataraxiaa marked this pull request as ready for review May 20, 2024 16:41
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the code changes, but still need to test the platform PRs

Copy link

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

@github-actions github-actions bot added the stale label May 31, 2024
@aataraxiaa aataraxiaa merged commit cd7850d into main Jun 3, 2024
7 checks passed
@aataraxiaa aataraxiaa deleted the pete/dbp-locked-keychain-access-and-migration branch June 3, 2024 09:40
samsymons added a commit that referenced this pull request Jun 3, 2024
* main:
  Enable DBP Keychain Item Accessibility Migration (#827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants