Update BSK due to iOS changes. #2776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoreymendez
changed the title
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
github-actions
bot
added
the
bot: not in app board
diegoreymendez
removed
the
bot: not in app board
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
approved these changes
May 24, 2024
samsymons
approved these changes
May 24, 2024
# By Daniel Bernal (1) and others # Via GitHub * main: Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
pushed a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 24, 2024
iOS: duckduckgo/iOS#2795 macOS: duckduckgo/macos-browser#2776 What kind of version bump will this require?: Minor Description Let's remove the VPN waitlist code.
samsymons
pushed a commit
to duckduckgo/iOS
that referenced
this pull request
May 24, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207178910368620/f macOS: duckduckgo/macos-browser#2776 BSK: duckduckgo/BrowserServicesKit#801 Description Let's remove the VPN waitlist code from iOS.
samsymons
added a commit
that referenced
this pull request
May 24, 2024
samsymons
added a commit
that referenced
this pull request
May 30, 2024
* main: (33 commits) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816) Update PeopleWhiz Broker Files to use hash id (#2814) Update BSK due to iOS changes. (#2776) Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) ...
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
# By Elle Sullivan (10) and others # Via GitHub (6) and others * main: (42 commits) Update autoconsent to v10.9.0 (#2822) Bump version to 1.90.0 (196) Revert "Add PIPAgent entitlement (#2821)" (#2823) Bump version to 1.90.0 (195) Bump version to 1.90.0 (194) Add PIPAgent entitlement (#2821) Fixes some VPN uninstallation issues (#2820) Bump version to 1.90.0 (193) Remove autofill survey (#2819) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816) Update PeopleWhiz Broker Files to use hash id (#2814) Update BSK due to iOS changes. (#2776) Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) Autofill engagement KPIs for pixel reporting (#2806) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207178910368620/f
iOS: duckduckgo/iOS#2795
BSK: duckduckgo/BrowserServicesKit#801
Description
Updating BSK due to iOS changes to ensure it integrates well with macOS.
Testing
Just check CI is green.
Internal references:
Software Engineering Expectations
Technical Design Template