Removes VPN waitlist and beta code #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
diegoreymendez
commented
May 14, 2024
Tests/BrowserServicesKitTests/Resources/remote-messaging-config.json
Outdated
Show resolved
Hide resolved
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
samsymons
approved these changes
May 24, 2024
# Via GitHub * main: Add `survey` action and Privacy Pro attributes (#826) # Conflicts: # Sources/RemoteMessaging/Matchers/UserAttributeMatcher.swift # Tests/BrowserServicesKitTests/RemoteMessaging/Mappers/JsonToRemoteConfigModelMapperTests.swift # Tests/BrowserServicesKitTests/RemoteMessaging/Matchers/UserAttributeMatcherTests.swift # Tests/BrowserServicesKitTests/RemoteMessaging/RemoteMessagingConfigMatcherTests.swift # Tests/BrowserServicesKitTests/RemoteMessaging/RemoteMessagingConfigProcessorTests.swift
samsymons
pushed a commit
to duckduckgo/macos-browser
that referenced
this pull request
May 24, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207178910368620/f iOS: duckduckgo/iOS#2795 BSK: duckduckgo/BrowserServicesKit#801 Description Updating BSK due to iOS changes to ensure it integrates well with macOS.
samsymons
pushed a commit
to duckduckgo/iOS
that referenced
this pull request
May 24, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1207178910368620/f macOS: duckduckgo/macos-browser#2776 BSK: duckduckgo/BrowserServicesKit#801 Description Let's remove the VPN waitlist code from iOS.
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
* main: Replace unowned reference with weak one (#832) Removes VPN waitlist and beta code (#801) Add `survey` action and Privacy Pro attributes (#826) Autofill engagement KPIs for pixel reporting (#830) Bump C-S-S to 5.17.0 (#828) ensure bookmarks can be shown in top hits (#818) Subscription refactoring (#815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1207178910368620/f
iOS: duckduckgo/iOS#2795
macOS: duckduckgo/macos-browser#2776
What kind of version bump will this require?: Minor
Description
Let's remove the VPN waitlist code.
Testing
Check platform specific PRs for testing instructions.
Internal references:
Software Engineering Expectations
Technical Design Template