Stop first scan completed notification being sent if there's an error #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THISISDINOSAUR
requested review from
Bunn and
jotaemepereira
and removed request for
Bunn
jotaemepereira
approved these changes
Apr 23, 2024
THISISDINOSAUR
deleted the
elle/dbp-fix-first-scan-completed-notification
branch
This was referenced Apr 24, 2024
THISISDINOSAUR
added a commit
that referenced
this pull request
Apr 24, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207148631921399/f and https://app.asana.com/0/1199230911884351/1207152863082294/f Tech Design URL: CC: **Description**: Combines #2685 and #2690 to merge them into an internal release **Steps to test this PR**: 1. Follow the steps in the two individual PRs <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
ayoy
pushed a commit
that referenced
this pull request
Apr 24, 2024
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207148631921399/f https://app.asana.com/0/1199230911884351/1207152863082294/f Tech Design URL: CC: **Description**: Combines #2685 and #2690 to merge them into an internal release **Steps to test this PR**: 1. Follow the steps in the two individual PRs <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
samsymons
added a commit
that referenced
this pull request
Apr 24, 2024
* main: (22 commits) Fix DataBrokerProtectionProcessor.swift lint Fix SwiftLint Add parameter allowed encoding to error descriptions (#2691) Remove debug flags Bump version to 1.85.0 (174) Revert interrupt logic (#2699) Fix downloads not appearing (#2693) Bump version to 1.85.0 (173) DBP interrupt fixes for release (#2696) Bookmark All Tabs (#2683) Fix DBP interrupt function not being cleared on succesful completion (#2690) Bump version to 1.85.0 (172) Validate DBP permissions (#2673) Bump BSK (#2688) Add Untitled tab title (#2650) Stop first scan completed notification being sent if there's an error (#2685) DBP: Rename scanAllBrokers to startManualScan (#2679) macOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2652) Bump version to 1.85.0 (171) [Release PR] Link Lottie with the NetworkProtectionUI library (#2676) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207148631921399/f
Tech Design URL:
CC:
Description:
Stops the "first scan notification' being sent if there is an error. Since we've added a new interrupted error, it will get a lot more common if we don't fix it before releasing.
We seem to have other issues relating to scan completion that this doesn't fix,
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation