DBP interrupt fixes for internal release #2695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/276630244458377/1206981108316772/f **Description**: Add DBP debug status menu icon. This is turned off by default and can only be turned on via debug menu
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207137555703948/f Tech Design URL: CC: **Description**: See parent task, fixes some selectors that were pulling in phone numbers instead of relatives.
Task/Issue URL: https://app.asana.com/0/1205842942115003/1206999268603553/f **Description**: Replaced local PixelKit with BSK's PixelKit
This work implements bundle-specific Keychain storage for our L1 keys, L2 keys and L2 encryption passwords.
…#2685) Task/Issue URL: https://app.asana.com/0/1199230911884351/1207148631921399/f Tech Design URL: CC: **Description**: Stops the "first scan notification' being sent if there is an error. Since we've added a new interrupted error, it will get a lot more common if we don't fix it before releasing. We seem to have other issues relating to scan completion that this doesn't fix, **Steps to test this PR**: 1. Test that you can replicate the original issue on main by forcing a "oneTimeError" in scanAllBrokers and checking you see the notification 2. Test the same thing on this PR, you shouldn't see a notification 3. Test that when scans complete you do see a notification <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> --- ###### Internal references: [Pull Request Review Checklist](https://app.asana.com/0/1202500774821704/1203764234894239/f) [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) [Pull Request Documentation](https://app.asana.com/0/1202500774821704/1204012835277482/f)
…le/dbp-fix-clearing-function-to-interrupt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199230911884351/1207148631921399/f and https://app.asana.com/0/1199230911884351/1207152863082294/f
Tech Design URL:
CC:
Description:
Combines #2685 and #2690 to merge them into an internal release
Steps to test this PR:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation