Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription Caching #2368

Merged
merged 13 commits into from
Mar 11, 2024
Merged

Subscription Caching #2368

merged 13 commits into from
Mar 11, 2024

Conversation

afterxleep
Copy link
Contributor

@afterxleep afterxleep commented Mar 9, 2024 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1206800657723184/f
BSK PR: duckduckgo/BrowserServicesKit#710

Description:

  • Bumps BSK to use subscription caching and updates previously used cache in Settings
  • Push canceled event to the Weview on user cancellation

Steps to test this PR:

  1. Get a subscription (Apple)
  2. Cancel in the Apple dialog. Confirm event 'canceled' is passed to the Webview (Breakpoint here)
  3. Smoke test Subscription Purchase / Removal / Restore

@afterxleep afterxleep requested a review from miasma13 March 9, 2024 23:36
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 9, 2024
@afterxleep afterxleep mentioned this pull request Mar 9, 2024
Merged
@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 10, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 10, 2024
@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 10, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 10, 2024
@afterxleep afterxleep changed the title Bump BSK (Subscription Caching) Subscription Caching Mar 10, 2024
@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to macOS App Board Asana project label Mar 10, 2024
afterxleep added a commit to duckduckgo/BrowserServicesKit that referenced this pull request Mar 11, 2024
@afterxleep
Subscriptions: Implement Caching for Subscription Info (#710)
4042a8e 
Task/Issue URL: https://app.asana.com/0/0/1206800657723184/f
iOS PR: duckduckgo/iOS#2569
macOS PR: duckduckgo/macos-browser#2368
What kind of version bump will this require?: Minor

Description:

Implements basic caching for Subscription info
Maintains current static approach for SubscriptionService
Adds proper UserDefault keys to avoid conflicts
Makes AppGroup optional in UserDefaultsCache
Adds method to reset cache in SubscriptionService and call from Signout
@afterxleep afterxleep merged commit ba5624d into main Mar 11, 2024
17 checks passed
@afterxleep afterxleep deleted the daniel/subscription.caching branch March 11, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @miasma13